From: Caleb Connolly <caleb@connolly.tech>
To: caleb@connolly.tech, Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: ejb@linux.ibm.com, stanley.chu@mediatek.com, cang@codeaurora.org,
beanhuo@micron.com, jaegeuk@kernel.org, asutoshd@codeaurora.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Nitin Rawat <nitirawa@codeaurora.org>
Subject: [RESEND PATCH v2 3/3] scsi: ufshcd: remove version check
Date: Tue, 09 Mar 2021 12:03:09 +0000 [thread overview]
Message-ID: <20210309120212.119451-4-caleb@connolly.tech> (raw)
In-Reply-To: <20210309120212.119451-1-caleb@connolly.tech>
This check is redundant as all UFS versions are currently supported.
Signed-off-by: Nitin Rawat <nitirawa@codeaurora.org>
Signed-off-by: Caleb Connolly <caleb@connolly.tech>
---
drivers/scsi/ufs/ufshcd.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index f4d4b885d4df..a6f317f0dc9b 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -9291,10 +9291,6 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq)
/* Get UFS version supported by the controller */
hba->ufs_version = ufshcd_get_ufs_version(hba);
- if (hba->ufs_version < ufshci_version(1, 0))
- dev_err(hba->dev, "invalid UFS version 0x%x\n",
- hba->ufs_version);
-
/* Get Interrupt bit mask per version */
hba->intr_mask = ufshcd_get_intr_mask(hba);
--
2.29.2
prev parent reply other threads:[~2021-03-09 12:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 12:02 RESEND v2: scsi: ufshcd: use a macro for UFS versions Caleb Connolly
2021-03-09 12:02 ` [RESEND PATCH v2 1/3] scsi: ufshcd: use a function to calculate versions Caleb Connolly
2021-03-09 14:55 ` Christoph Hellwig
2021-03-09 12:02 ` [RESEND PATCH v2 2/3] scsi: ufs: qcom: use ufshci_version function Caleb Connolly
2021-03-09 12:03 ` Caleb Connolly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309120212.119451-4-caleb@connolly.tech \
--to=caleb@connolly.tech \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cang@codeaurora.org \
--cc=ejb@linux.ibm.com \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nitirawa@codeaurora.org \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).