From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61E76C433DB for ; Tue, 9 Mar 2021 14:56:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12FA965259 for ; Tue, 9 Mar 2021 14:56:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231668AbhCIOzw (ORCPT ); Tue, 9 Mar 2021 09:55:52 -0500 Received: from verein.lst.de ([213.95.11.211]:60528 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230116AbhCIOzq (ORCPT ); Tue, 9 Mar 2021 09:55:46 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 3459568B05; Tue, 9 Mar 2021 15:55:43 +0100 (CET) Date: Tue, 9 Mar 2021 15:55:43 +0100 From: Christoph Hellwig To: Caleb Connolly Cc: Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , ejb@linux.ibm.com, stanley.chu@mediatek.com, cang@codeaurora.org, beanhuo@micron.com, jaegeuk@kernel.org, asutoshd@codeaurora.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: [RESEND PATCH v2 1/3] scsi: ufshcd: use a function to calculate versions Message-ID: <20210309145543.GB14621@lst.de> References: <20210309120212.119451-1-caleb@connolly.tech> <20210309120212.119451-2-caleb@connolly.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210309120212.119451-2-caleb@connolly.tech> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 09, 2021 at 12:02:47PM +0000, Caleb Connolly wrote: > +static inline u32 ufshci_version(u32 major, u32 minor) { > + return (((major) << 8) + ((minor) << 4)); > +} Kernel style puts the opening curly brace on a separate line. Also for an inline function adding parentheses is not required (unlike for macros). Otherwise this looks good: Reviewed-by: Christoph Hellwig