From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 432CFC433E6 for ; Wed, 10 Mar 2021 07:49:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 141D76500E for ; Wed, 10 Mar 2021 07:49:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231158AbhCJHtH (ORCPT ); Wed, 10 Mar 2021 02:49:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229904AbhCJHsz (ORCPT ); Wed, 10 Mar 2021 02:48:55 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38DF8C061761; Tue, 9 Mar 2021 23:48:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PPu2UvPAXkyCwFNg4js+GYjpdd291lCCF0Weo8KPpZk=; b=mXP8wHF6IsGSDLqffxgt2JYE83 qwObZaj/YT82ac4J2iNq7TICkg37FIJdhBZ7rPgqi58NKmIdU0RIT/TWXcKqdwDF4/Vc6EsJTbQXi wGv4xwkdQP650Q/vnNOe3QZWME2pPu+NITM8msfTOyCTl4YKEnuhbJth9seQ8/2AtLluZb6EneT23 JOFXbV6nQ9zi/cJ026K0LxaoRX8WmA2iUcKePObJY/ulzEDlL5wqLiy7t9i7clMsoPorMe0FlFFXk d6EVSYvGiuBZBnm75txDqDGomyhYrL0DmqCohpCtFhGQqa3WQUmPiCR9ZY9yJNmBIVzRh7EtWhF1f MlCPH/kw==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lJtaA-002mla-HJ; Wed, 10 Mar 2021 07:48:42 +0000 Date: Wed, 10 Mar 2021 07:48:38 +0000 From: Christoph Hellwig To: Alex Williamson Cc: cohuck@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, jgg@nvidia.com, peterx@redhat.com Subject: Re: [PATCH v1 02/14] vfio: Update vfio_add_group_dev() API Message-ID: <20210310074838.GA662265@infradead.org> References: <161523878883.3480.12103845207889888280.stgit@gimli.home> <161524006056.3480.3931750068527641030.stgit@gimli.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <161524006056.3480.3931750068527641030.stgit@gimli.home> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 08, 2021 at 02:47:40PM -0700, Alex Williamson wrote: > Rather than an errno, return a pointer to the opaque vfio_device > to allow the bus driver to call into vfio-core without additional > lookups and references. Note that bus drivers are still required > to use vfio_del_group_dev() to teardown the vfio_device. > > Signed-off-by: Alex Williamson This looks like it is superseded by the vfio: Split creation of a vfio_device into init and register ops patch from Jason, which provides a much nicer API.