From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D9F79C43381
	for <linux-kernel@archiver.kernel.org>; Wed, 10 Mar 2021 08:05:14 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id B5CA964FE5
	for <linux-kernel@archiver.kernel.org>; Wed, 10 Mar 2021 08:05:14 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231996AbhCJIEn (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 10 Mar 2021 03:04:43 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60686 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229643AbhCJIER (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 10 Mar 2021 03:04:17 -0500
Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54C2FC06174A;
        Wed, 10 Mar 2021 00:04:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=m7vmehVG7oO9qabFkyYe2PuNA+zX19AuD9m9j6F9h3o=; b=MxAhLHBJCSxXNb2rhkwDa7lqqP
        hc95I57qL/cR4qO72l9jqzsqRRWJr97fynBenR/WulxAhciyd3jLRJk/5i/E8mr9rhs612A/dhfZx
        NfusLgBdvJFEIKrlpwAk+k65Fv3VDIUkcD0RvsHxAWU03BHyfkRTRoBqyMkyllsPAynXaWf2dAF9z
        QVJGScRrG7Tfl8sNELWHSh0VfV5p745eFlbPuJCg9YDA27wlgii9WM4vph7L/WfXThZXF2wWLPDvN
        nEvQiJ4oCv0Znd2XZBsuUBbziNuIIURmMCW5OlOXI25cMgOhHtO8z5wdGs+0VGy7jWgdEhpBCqrST
        Qyw7P9CA==;
Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux))
        id 1lJtp0-002oaw-Tq; Wed, 10 Mar 2021 08:04:01 +0000
Date:   Wed, 10 Mar 2021 08:03:58 +0000
From:   Christoph Hellwig <hch@infradead.org>
To:     Alex Williamson <alex.williamson@redhat.com>
Cc:     cohuck@redhat.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, jgg@nvidia.com, peterx@redhat.com
Subject: Re: [PATCH v1 11/14] vfio/type1: Register device notifier
Message-ID: <20210310080358.GD662265@infradead.org>
References: <161523878883.3480.12103845207889888280.stgit@gimli.home>
 <161524015876.3480.18404153016941080011.stgit@gimli.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <161524015876.3480.18404153016941080011.stgit@gimli.home>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by casper.infradead.org. See http://www.infradead.org/rpr.html
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +
> +		if (!dma->pfnmap) {
> +			struct vfio_device *device;
> +			unsigned long base_pfn;
> +			struct pfnmap_obj *pfnmap;

Please factor this whole block into a separate helper to keep it
readable.