From: Andrew Morton <akpm@linux-foundation.org>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Chuck Lever <chuck.lever@oracle.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux-Net <netdev@vger.kernel.org>, Linux-MM <linux-mm@kvack.org>,
Linux-NFS <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 0/5] Introduce a bulk order-0 page allocator with two in-tree users
Date: Wed, 10 Mar 2021 15:47:04 -0800 [thread overview]
Message-ID: <20210310154704.9389055d0be891a0c3549cc2@linux-foundation.org> (raw)
In-Reply-To: <20210310104618.22750-1-mgorman@techsingularity.net>
On Wed, 10 Mar 2021 10:46:13 +0000 Mel Gorman <mgorman@techsingularity.net> wrote:
> This series introduces a bulk order-0 page allocator with sunrpc and
> the network page pool being the first users.
<scratches head>
Right now, the [0/n] doesn't even tell us that it's a performance
patchset!
The whole point of this patchset appears to appear in the final paragraph
of the final patch's changelog.
: For XDP-redirect workload with 100G mlx5 driver (that use page_pool)
: redirecting xdp_frame packets into a veth, that does XDP_PASS to create
: an SKB from the xdp_frame, which then cannot return the page to the
: page_pool. In this case, we saw[1] an improvement of 18.8% from using
: the alloc_pages_bulk API (3,677,958 pps -> 4,368,926 pps).
Much more detail on the overall objective and the observed results,
please?
Also, that workload looks awfully corner-casey. How beneficial is this
work for more general and widely-used operations?
> The implementation is not
> particularly efficient and the intention is to iron out what the semantics
> of the API should have for users. Once the semantics are ironed out, it can
> be made more efficient.
And some guesstimates about how much benefit remains to be realized
would be helpful.
next prev parent reply other threads:[~2021-03-10 23:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 10:46 [PATCH 0/5] Introduce a bulk order-0 page allocator with two in-tree users Mel Gorman
2021-03-10 10:46 ` [PATCH 1/5] SUNRPC: Set rq_page_end differently Mel Gorman
2021-03-10 10:46 ` [PATCH 2/5] mm/page_alloc: Add a bulk page allocator Mel Gorman
2021-03-10 23:46 ` Andrew Morton
2021-03-11 8:42 ` Mel Gorman
2021-03-12 11:46 ` Jesper Dangaard Brouer
2021-03-12 13:44 ` Mel Gorman
2021-03-12 14:58 ` Matthew Wilcox
2021-03-12 16:03 ` Mel Gorman
2021-03-12 21:08 ` Matthew Wilcox
2021-03-13 13:16 ` Mel Gorman
2021-03-13 16:39 ` Matthew Wilcox
2021-03-13 16:56 ` Chuck Lever III
2021-03-13 19:33 ` Matthew Wilcox
2021-03-14 12:52 ` Mel Gorman
2021-03-14 15:22 ` Chuck Lever III
2021-03-15 10:42 ` Mel Gorman
2021-03-15 16:42 ` Jesper Dangaard Brouer
2021-03-19 17:10 ` Jesper Dangaard Brouer
2021-03-12 12:43 ` Matthew Wilcox
2021-03-12 14:15 ` Mel Gorman
2021-03-10 10:46 ` [PATCH 3/5] SUNRPC: Refresh rq_pages using " Mel Gorman
2021-03-10 10:46 ` [PATCH 4/5] net: page_pool: refactor dma_map into own function page_pool_dma_map Mel Gorman
2021-03-10 10:46 ` [PATCH 5/5] net: page_pool: use alloc_pages_bulk in refill code path Mel Gorman
2021-03-10 23:47 ` Andrew Morton [this message]
2021-03-11 8:48 ` [PATCH 0/5] Introduce a bulk order-0 page allocator with two in-tree users Mel Gorman
2021-03-12 15:10 ` Matthew Wilcox
-- strict thread matches above, loose matches on Subject: below --
2021-03-01 16:11 Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310154704.9389055d0be891a0c3549cc2@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=brouer@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).