From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DB5AC433DB for ; Thu, 11 Mar 2021 11:38:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F48064FC9 for ; Thu, 11 Mar 2021 11:38:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232768AbhCKLhj (ORCPT ); Thu, 11 Mar 2021 06:37:39 -0500 Received: from verein.lst.de ([213.95.11.211]:40565 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232679AbhCKLhJ (ORCPT ); Thu, 11 Mar 2021 06:37:09 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 0C4B268B05; Thu, 11 Mar 2021 12:37:07 +0100 (CET) Date: Thu, 11 Mar 2021 12:37:06 +0100 From: Christoph Hellwig To: Jason Gunthorpe Cc: Christoph Hellwig , Max Gurtovoy , alex.williamson@redhat.com, cohuck@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, liranl@nvidia.com, oren@nvidia.com, tzahio@nvidia.com, leonro@nvidia.com, yarong@nvidia.com, aviadye@nvidia.com, shahafs@nvidia.com, artemp@nvidia.com, kwankhede@nvidia.com, ACurrid@nvidia.com, cjia@nvidia.com, yishaih@nvidia.com, mjrosato@linux.ibm.com, aik@ozlabs.ru Subject: Re: [PATCH 9/9] vfio/pci: export igd support into vendor vfio_pci driver Message-ID: <20210311113706.GC17183@lst.de> References: <20210309083357.65467-1-mgurtovoy@nvidia.com> <20210309083357.65467-10-mgurtovoy@nvidia.com> <20210310081508.GB4364@lst.de> <20210310123127.GT2356281@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210310123127.GT2356281@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 10, 2021 at 08:31:27AM -0400, Jason Gunthorpe wrote: > Yes, that needs more refactoring. I'm viewing this series as a > "statement of intent" and once we commit to doing this we can go > through the bigger effort to split up vfio_pci_core and tidy its API. > > Obviously this is a big project, given the past comments I don't want > to send more effort here until we see a community consensus emerge > that this is what we want to do. If we build a sub-driver instead the > work is all in the trash bin. So my viewpoint here is that this work doesn't seem very useful for the existing subdrivers given how much compat pain there is. It defintively is the right way to go for a new driver.