linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org, linux-kernel@vger.kernel.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Tzung-Bi Shih <tzungbi@google.com>,
	Jiaxin Yu <jiaxin.yu@mediatek.com>,
	"Shane.Chien" <shane.chien@mediatek.com>,
	linux-arm-kernel@lists.infradead.org (moderated
	list:ARM/Mediatek SoC support),
	linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek
	SoC support)
Subject: [PATCH 14/23] ASoC: mt6359: remove useless assignment
Date: Fri, 12 Mar 2021 12:22:37 -0600	[thread overview]
Message-ID: <20210312182246.5153-15-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20210312182246.5153-1-pierre-louis.bossart@linux.intel.com>

cppcheck warning:

sound/soc/codecs/mt6359.c:242:19: style: Variable 'stage' is assigned a value that is never used. [unreadVariable]
 int i = 0, stage = 0;
                  ^
sound/soc/codecs/mt6359.c:260:19: style: Variable 'stage' is assigned a value that is never used. [unreadVariable]
 int i = 0, stage = 0;
                  ^
sound/soc/codecs/mt6359.c:274:8: style: Variable 'i' is assigned a value that is never used. [unreadVariable]
 int i = 0, stage = 0;
       ^
sound/soc/codecs/mt6359.c:274:19: style: Variable 'stage' is assigned a value that is never used. [unreadVariable]
 int i = 0, stage = 0;
                  ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/codecs/mt6359.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/mt6359.c b/sound/soc/codecs/mt6359.c
index 6f4b1da52082..b909b36582b7 100644
--- a/sound/soc/codecs/mt6359.c
+++ b/sound/soc/codecs/mt6359.c
@@ -239,7 +239,7 @@ static void zcd_disable(struct mt6359_priv *priv)
 
 static void hp_main_output_ramp(struct mt6359_priv *priv, bool up)
 {
-	int i = 0, stage = 0;
+	int i, stage;
 	int target = 7;
 
 	/* Enable/Reduce HPL/R main output stage step by step */
@@ -257,7 +257,7 @@ static void hp_main_output_ramp(struct mt6359_priv *priv, bool up)
 
 static void hp_aux_feedback_loop_gain_ramp(struct mt6359_priv *priv, bool up)
 {
-	int i = 0, stage = 0;
+	int i, stage;
 	int target = 0xf;
 
 	/* Enable/Reduce HP aux feedback loop gain step by step */
-- 
2.25.1


  parent reply	other threads:[~2021-03-12 18:24 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12 18:22 [PATCH 00/23] ASoC: codecs: remove cppcheck warnings Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 01/23] ASoC: ab8500-codec: remove useless structure Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 02/23] ASoC: ad1836: remove useless return Pierre-Louis Bossart
2021-03-12 18:50   ` Lars-Peter Clausen
2021-03-12 18:22 ` [PATCH 03/23] ASoC: adau1977: " Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 04/23] ASoC: cros_ec_codec: remove null pointer dereference warning Pierre-Louis Bossart
2021-03-15 10:39   ` Enric Balletbo i Serra
2021-03-12 18:22 ` [PATCH 05/23] ASoC: cx2070x: remove useless assignment Pierre-Louis Bossart
2021-03-14  8:30   ` Takashi Iwai
2021-03-14  8:30   ` Takashi Iwai
2021-03-12 18:22 ` [PATCH 06/23] ASoC: cx2070x: remove duplicate else branch Pierre-Louis Bossart
2021-03-14  8:32   ` Takashi Iwai
2021-03-12 18:22 ` [PATCH 07/23] ASoC: da7219-aad: remove useless initialization Pierre-Louis Bossart
2021-03-15 14:50   ` Adam Thomson
2021-03-12 18:22 ` [PATCH 08/23] ASoC: hdac_hdmi: remove useless initializations Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 09/23] ASoC: hdac_hdmi: align function arguments Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 10/23] ASoC: hdmi-codec: remove useless initialization Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 11/23] ASoC: hdmi-codec: remove unused spk_mask member Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 12/23] ASoC: max98090: remove useless assignment Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 13/23] ASoC: mt6358: remove useless initializations Pierre-Louis Bossart
2021-03-12 18:22 ` Pierre-Louis Bossart [this message]
2021-03-12 18:22 ` [PATCH 15/23] ASoC: nau8825: remove useless assignment Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 16/23] ASoC: pcm1681: " Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 17/23] ASoC: sigmadsp: align function prototype Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 18/23] ASoC: sti-sas: remove unused struct members Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 19/23] ASoC: tas2562: remove useless assignment Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 20/23] ASoC: tas2562: remove warning on return value Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 21/23] ASoC: tas2770: remove useless initialization Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 22/23] ASoC: tlv320dac33: clarify expression Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 23/23] ASoC: tscs454: remove useless test on PLL disable Pierre-Louis Bossart
2021-03-18 18:33 ` [PATCH 00/23] ASoC: codecs: remove cppcheck warnings Mark Brown
2021-03-18 18:36   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210312182246.5153-15-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jiaxin.yu@mediatek.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=perex@perex.cz \
    --cc=shane.chien@mediatek.com \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    --cc=tzungbi@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).