* [PATCH] mtd: spi-nor: Update comment about the default flash parameters
@ 2021-03-15 5:56 Tudor Ambarus
2021-03-15 8:28 ` Pratyush Yadav
2021-03-17 5:52 ` Tudor Ambarus
0 siblings, 2 replies; 3+ messages in thread
From: Tudor Ambarus @ 2021-03-15 5:56 UTC (permalink / raw)
To: michael, p.yadav, vigneshr; +Cc: linux-mtd, linux-kernel, Tudor Ambarus
s/legacy/default. spi_nor_info_init_params initializes some default
flash parameters and settings that can be overwritten when parsing
SFDP, or by fixup hooks. There's nothing legacy about them, they are
just some default settings, if not otherwise discovered or specified.
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
drivers/mtd/spi-nor/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
index 4a315cb1c4db..26f681cd3a98 100644
--- a/drivers/mtd/spi-nor/core.c
+++ b/drivers/mtd/spi-nor/core.c
@@ -2913,7 +2913,7 @@ static void spi_nor_info_init_params(struct spi_nor *nor)
struct device_node *np = spi_nor_get_flash_node(nor);
u8 i, erase_mask;
- /* Initialize legacy flash parameters and settings. */
+ /* Initialize default flash parameters and settings. */
params->quad_enable = spi_nor_sr2_bit1_quad_enable;
params->set_4byte_addr_mode = spansion_set_4byte_addr_mode;
params->setup = spi_nor_default_setup;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: spi-nor: Update comment about the default flash parameters
2021-03-15 5:56 [PATCH] mtd: spi-nor: Update comment about the default flash parameters Tudor Ambarus
@ 2021-03-15 8:28 ` Pratyush Yadav
2021-03-17 5:52 ` Tudor Ambarus
1 sibling, 0 replies; 3+ messages in thread
From: Pratyush Yadav @ 2021-03-15 8:28 UTC (permalink / raw)
To: Tudor Ambarus; +Cc: michael, vigneshr, linux-mtd, linux-kernel
On 15/03/21 07:56AM, Tudor Ambarus wrote:
> s/legacy/default. spi_nor_info_init_params initializes some default
> flash parameters and settings that can be overwritten when parsing
> SFDP, or by fixup hooks. There's nothing legacy about them, they are
> just some default settings, if not otherwise discovered or specified.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
> ---
> drivers/mtd/spi-nor/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index 4a315cb1c4db..26f681cd3a98 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -2913,7 +2913,7 @@ static void spi_nor_info_init_params(struct spi_nor *nor)
> struct device_node *np = spi_nor_get_flash_node(nor);
> u8 i, erase_mask;
>
> - /* Initialize legacy flash parameters and settings. */
> + /* Initialize default flash parameters and settings. */
> params->quad_enable = spi_nor_sr2_bit1_quad_enable;
> params->set_4byte_addr_mode = spansion_set_4byte_addr_mode;
> params->setup = spi_nor_default_setup;
> --
> 2.25.1
>
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: spi-nor: Update comment about the default flash parameters
2021-03-15 5:56 [PATCH] mtd: spi-nor: Update comment about the default flash parameters Tudor Ambarus
2021-03-15 8:28 ` Pratyush Yadav
@ 2021-03-17 5:52 ` Tudor Ambarus
1 sibling, 0 replies; 3+ messages in thread
From: Tudor Ambarus @ 2021-03-17 5:52 UTC (permalink / raw)
To: michael, p.yadav, Tudor Ambarus, vigneshr; +Cc: linux-kernel, linux-mtd
On Mon, 15 Mar 2021 07:56:34 +0200, Tudor Ambarus wrote:
> s/legacy/default. spi_nor_info_init_params initializes some default
> flash parameters and settings that can be overwritten when parsing
> SFDP, or by fixup hooks. There's nothing legacy about them, they are
> just some default settings, if not otherwise discovered or specified.
Applied to spi-nor/next, thanks!
[1/1] mtd: spi-nor: Update comment about the default flash parameters
https://git.kernel.org/mtd/c/79321e752aff
Best regards,
--
Tudor Ambarus <tudor.ambarus@microchip.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-17 5:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-15 5:56 [PATCH] mtd: spi-nor: Update comment about the default flash parameters Tudor Ambarus
2021-03-15 8:28 ` Pratyush Yadav
2021-03-17 5:52 ` Tudor Ambarus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).