From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3064DC4332B for ; Mon, 15 Mar 2021 19:10:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 097C164F42 for ; Mon, 15 Mar 2021 19:10:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232861AbhCOTKW (ORCPT ); Mon, 15 Mar 2021 15:10:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232994AbhCOTKN (ORCPT ); Mon, 15 Mar 2021 15:10:13 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EC23C06174A; Mon, 15 Mar 2021 12:10:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mkpF9omMUUFgPhO7wM2oolIv2L3IwnCTiRJGLYj/QNo=; b=m+fRbbsfcHaiqSu+dUQambcli/ ayhSDuAmTMfgav8aX4P6JUjk2UJMjfrhSSVInwiDYtTmQxyp2LuXKNZkV09fswCHEPBjWuSH3bA2m kw7a7sJDLRbm+EJ7comRFCaOHYRkn3XUtgaY3jrPctWZMWbE6z59Ix5nvs/L/ynPTX2t4sHtWqZBn hEYBcI24VItDXo8c6KddZqLKi1r1xMhVm0hS6T0LGrd+xXaVwZs/YJooBaLz9fsWlCJJHQCdDGjNU suEBhlzf3181euFSUmfd2uuXPNZDjtfp5u99R441myZp9pbxLsVwgWZXhpZFuh7klOeWsPWIRHnZF J5kENouA==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lLsaO-000dXn-R4; Mon, 15 Mar 2021 19:09:09 +0000 Date: Mon, 15 Mar 2021 19:09:04 +0000 From: Christoph Hellwig To: Michal Hocko Cc: "Kirill A. Shutemov" , Hugh Dickins , Andrew Morton , "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v4 00/25] Page folios Message-ID: <20210315190904.GB150808@infradead.org> References: <20210305041901.2396498-1-willy@infradead.org> <20210313123658.ad2dcf79a113a8619c19c33b@linux-foundation.org> <20210315115501.7rmzaan2hxsqowgq@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 15, 2021 at 01:38:04PM +0100, Michal Hocko wrote: > I tend to agree here as well. The level compoud_head has spread out > silently is just too large. There are people coming up with all sorts of > optimizations to workaround that, and they are quite right that this is > somehing worth doing, but last attempts I have seen were very focused on > specific page flags handling which is imho worse wrt maintainability > than a higher level and type safe abstraction. I find it quite nice that > this doesn't really have to be a flag day conversion but it can be done > incrementally. > > I didn't get review the series yet and I cannot really promise anything > but from what I understand the conversion should be pretty > straightforward, albeit noisy. > > One thing that was really strange to me when seeing the concept for the > first time was the choice of naming (no I do not want to start any > bikeshedding) because it hasn't really resonated with the udnerlying > concept. Maybe just me as a non native speaker... page_head would have > been so much more straightforward but not something I really care about. That pretty much summarizes my opinion as well. I'll need to find some time to review the series as well.