From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8C97C433E6 for ; Tue, 16 Mar 2021 09:53:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC5FC65023 for ; Tue, 16 Mar 2021 09:53:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236383AbhCPJxY (ORCPT ); Tue, 16 Mar 2021 05:53:24 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:53216 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236376AbhCPJxU (ORCPT ); Tue, 16 Mar 2021 05:53:20 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 0CF2A1C0B8B; Tue, 16 Mar 2021 10:53:18 +0100 (CET) Date: Tue, 16 Mar 2021 10:53:17 +0100 From: Pavel Machek To: Pavel Machek Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Eric Dumazet , "David S. Miller" Subject: Re: [PATCH 4.19 012/120] tcp: annotate tp->write_seq lockless reads Message-ID: <20210316095317.GC12946@amd> References: <20210315135720.002213995@linuxfoundation.org> <20210315135720.418426545@linuxfoundation.org> <20210316095049.GB12946@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wxDdMuZNg1r63Hyj" Content-Disposition: inline In-Reply-To: <20210316095049.GB12946@amd> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wxDdMuZNg1r63Hyj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > From: Greg Kroah-Hartman > >=20 > > From: Eric Dumazet >=20 > Dup. Aha, sorry, crossed mails. Still I wonder if hiding assignment into macro is good: > > --- a/net/ipv4/tcp_minisocks.c > > +++ b/net/ipv4/tcp_minisocks.c > > @@ -510,7 +510,7 @@ struct sock *tcp_create_openreq_child(co > > newtp->app_limited =3D ~0U; > > =20 > > tcp_init_xmit_timers(newsk); > > - newtp->write_seq =3D newtp->pushed_seq =3D treq->snt_isn + 1; > > + WRITE_ONCE(newtp->write_seq, newtp->pushed_seq =3D treq->snt_isn + 1); >=20 > Would it be better to do assignment to pushed_seq outside of > WRITE_ONCE macro? This is ... "interesting". Best regards, Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --wxDdMuZNg1r63Hyj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmBQgA0ACgkQMOfwapXb+vK3yQCeLJ+76EJmgJy2npJfJUko//zp ujEAnj3DgTZ/NUoQ/Zf94PQ/UJBlZxvO =aDh+ -----END PGP SIGNATURE----- --wxDdMuZNg1r63Hyj--