* [PATCH] reset: RESET_BRCMSTB_RESCAL should depend on ARCH_BRCMSTB
@ 2021-03-16 13:37 Geert Uytterhoeven
2021-03-16 16:39 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2021-03-16 13:37 UTC (permalink / raw)
To: Philipp Zabel, Florian Fainelli, Jim Quinlan
Cc: linux-kernel, Geert Uytterhoeven
The Broadcom STB RESCAL reset controller is only present on Broadcom
BCM7216 platforms. Hence add a dependency on ARCH_BRCMSTB, to prevent
asking the user about this driver when configuring a kernel without
BCM7216 support.
Also, merely enabling CONFIG_COMPILE_TEST should not enable additional
code, and thus should not enable this driver by default.
Fixes: 4cf176e52397853e ("reset: Add Broadcom STB RESCAL reset controller")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/reset/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 4171c6f763858a03..6dba675bcec47777 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -59,7 +59,8 @@ config RESET_BRCMSTB
config RESET_BRCMSTB_RESCAL
bool "Broadcom STB RESCAL reset controller"
depends on HAS_IOMEM
- default ARCH_BRCMSTB || COMPILE_TEST
+ depends on ARCH_BRCMSTB || COMPILE_TEST
+ default ARCH_BRCMSTB
help
This enables the RESCAL reset controller for SATA, PCIe0, or PCIe1 on
BCM7216.
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] reset: RESET_BRCMSTB_RESCAL should depend on ARCH_BRCMSTB
2021-03-16 13:37 [PATCH] reset: RESET_BRCMSTB_RESCAL should depend on ARCH_BRCMSTB Geert Uytterhoeven
@ 2021-03-16 16:39 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2021-03-16 16:39 UTC (permalink / raw)
To: Geert Uytterhoeven, Philipp Zabel, Jim Quinlan; +Cc: linux-kernel
On 3/16/2021 6:37 AM, Geert Uytterhoeven wrote:
> The Broadcom STB RESCAL reset controller is only present on Broadcom
> BCM7216 platforms. Hence add a dependency on ARCH_BRCMSTB, to prevent
> asking the user about this driver when configuring a kernel without
> BCM7216 support.
>
> Also, merely enabling CONFIG_COMPILE_TEST should not enable additional
> code, and thus should not enable this driver by default.
>
> Fixes: 4cf176e52397853e ("reset: Add Broadcom STB RESCAL reset controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-16 16:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-16 13:37 [PATCH] reset: RESET_BRCMSTB_RESCAL should depend on ARCH_BRCMSTB Geert Uytterhoeven
2021-03-16 16:39 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).