ingenic-adc.c:undefined reference to `clk_get_parent'

ingenic-adc.c:undefined reference to `clk_get_parent'

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   1a4431a5db2bf800c647ee0ed87f2727b8d6c29c
commit: a07a4fe5ff460e99293c0d682421920d54e31d7f iio:adc:ingenic: drop of_match_ptr protection and include mod_devicetable.h
date:   8 months ago
config: mips-randconfig-p001-20210316 (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a07a4fe5ff460e99293c0d682421920d54e31d7f
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout a07a4fe5ff460e99293c0d682421920d54e31d7f
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
>> ingenic-adc.c:(.text+0x8c): undefined reference to `clk_get_parent'
   mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
   ingenic-adc.c:(.text+0x164): undefined reference to `clk_get_parent'

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25927 bytes --]

Re: ingenic-adc.c:undefined reference to `clk_get_parent'

[Randy Dunlap]

[add linux-clk + maintainers]

On 3/16/21 8:54 AM, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   1a4431a5db2bf800c647ee0ed87f2727b8d6c29c
> commit: a07a4fe5ff460e99293c0d682421920d54e31d7f iio:adc:ingenic: drop of_match_ptr protection and include mod_devicetable.h
> date:   8 months ago
> config: mips-randconfig-p001-20210316 (attached as .config)
> compiler: mips-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a07a4fe5ff460e99293c0d682421920d54e31d7f
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout a07a4fe5ff460e99293c0d682421920d54e31d7f
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
>>> ingenic-adc.c:(.text+0x8c): undefined reference to `clk_get_parent'
>    mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
>    ingenic-adc.c:(.text+0x164): undefined reference to `clk_get_parent'

Hi,

My guess (analysis) suggests that this problem is due to
a difference in when clk_get_parent() is available between
<linux/clk.h> where it depends on CONFIG_HAVE_CLK and
drivers/clk/clk.c, which is built iff CONFIG_COMMON_CLK.

Any comments/suggestions?

thanks.
-- 
~Randy

Re: ingenic-adc.c:undefined reference to `clk_get_parent'

[Andy Shevchenko]

On Mon, Apr 26, 2021 at 8:43 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> [add linux-clk + maintainers]
>
> On 3/16/21 8:54 AM, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   1a4431a5db2bf800c647ee0ed87f2727b8d6c29c
> > commit: a07a4fe5ff460e99293c0d682421920d54e31d7f iio:adc:ingenic: drop of_match_ptr protection and include mod_devicetable.h
> > date:   8 months ago
> > config: mips-randconfig-p001-20210316 (attached as .config)
> > compiler: mips-linux-gcc (GCC) 9.3.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a07a4fe5ff460e99293c0d682421920d54e31d7f
> >         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> >         git fetch --no-tags linus master
> >         git checkout a07a4fe5ff460e99293c0d682421920d54e31d7f
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> >    mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
> >>> ingenic-adc.c:(.text+0x8c): undefined reference to `clk_get_parent'
> >    mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
> >    ingenic-adc.c:(.text+0x164): undefined reference to `clk_get_parent'
>
> Hi,
>
> My guess (analysis) suggests that this problem is due to
> a difference in when clk_get_parent() is available between
> <linux/clk.h> where it depends on CONFIG_HAVE_CLK and
> drivers/clk/clk.c, which is built iff CONFIG_COMMON_CLK.
>
> Any comments/suggestions?

I haven't looked into it, but IIRC MIPS has its own clock API
implementation (or I mixed it with another arch?) and that's the root
of many issues like this around the kernel.

-- 
With Best Regards,
Andy Shevchenko

Re: ingenic-adc.c:undefined reference to `clk_get_parent'

[Randy Dunlap]

On 4/26/21 1:22 AM, Andy Shevchenko wrote:
> On Mon, Apr 26, 2021 at 8:43 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> [add linux-clk + maintainers]
>>
>> On 3/16/21 8:54 AM, kernel test robot wrote:
>>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>>> head:   1a4431a5db2bf800c647ee0ed87f2727b8d6c29c
>>> commit: a07a4fe5ff460e99293c0d682421920d54e31d7f iio:adc:ingenic: drop of_match_ptr protection and include mod_devicetable.h
>>> date:   8 months ago
>>> config: mips-randconfig-p001-20210316 (attached as .config)
>>> compiler: mips-linux-gcc (GCC) 9.3.0
>>> reproduce (this is a W=1 build):
>>>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>>         chmod +x ~/bin/make.cross
>>>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a07a4fe5ff460e99293c0d682421920d54e31d7f
>>>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>>>         git fetch --no-tags linus master
>>>         git checkout a07a4fe5ff460e99293c0d682421920d54e31d7f
>>>         # save the attached .config to linux build tree
>>>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
>>>
>>> If you fix the issue, kindly add following tag as appropriate
>>> Reported-by: kernel test robot <lkp@intel.com>
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>>    mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
>>>>> ingenic-adc.c:(.text+0x8c): undefined reference to `clk_get_parent'
>>>    mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
>>>    ingenic-adc.c:(.text+0x164): undefined reference to `clk_get_parent'
>>
>> Hi,
>>
>> My guess (analysis) suggests that this problem is due to
>> a difference in when clk_get_parent() is available between
>> <linux/clk.h> where it depends on CONFIG_HAVE_CLK and
>> drivers/clk/clk.c, which is built iff CONFIG_COMMON_CLK.
>>
>> Any comments/suggestions?
> 
> I haven't looked into it, but IIRC MIPS has its own clock API
> implementation (or I mixed it with another arch?) and that's the root
> of many issues like this around the kernel.


Thanks. I do see that (MIPS) CONFIG_RA7 and CONFIG_RALINK
provide their own clk_get_parent(), but neither of those is
enabled in the kernel config file.

I'll post some kind of patch later today.

-- 
~Randy