From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, Hannes Reinecke <hare@kernel.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Linux GmbH <hare@suse.com>,
"Leonard N. Zubkoff" <lnz@dandelion.com>,
linux-scsi@vger.kernel.org
Subject: [PATCH 09/18] scsi: myrs: Remove a couple of unused 'status' variables
Date: Wed, 17 Mar 2021 08:56:52 +0000 [thread overview]
Message-ID: <20210317085701.2891231-10-lee.jones@linaro.org> (raw)
In-Reply-To: <20210317085701.2891231-1-lee.jones@linaro.org>
Fixes the following W=1 kernel build warning(s):
drivers/scsi/myrs.c: In function ‘consistency_check_show’:
drivers/scsi/myrs.c:1193:16: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]
drivers/scsi/myrs.c: In function ‘myrs_get_resync’:
drivers/scsi/myrs.c:1984:5: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]
Cc: Hannes Reinecke <hare@kernel.org>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Linux GmbH <hare@suse.com>
Cc: "Leonard N. Zubkoff" <lnz@dandelion.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/myrs.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/myrs.c b/drivers/scsi/myrs.c
index 4adf9ded296aa..48e399f057d5c 100644
--- a/drivers/scsi/myrs.c
+++ b/drivers/scsi/myrs.c
@@ -1190,7 +1190,6 @@ static ssize_t consistency_check_show(struct device *dev,
struct myrs_hba *cs = shost_priv(sdev->host);
struct myrs_ldev_info *ldev_info;
unsigned short ldev_num;
- unsigned char status;
if (sdev->channel < cs->ctlr_info->physchan_present)
return snprintf(buf, 32, "physical device - not checking\n");
@@ -1199,7 +1198,7 @@ static ssize_t consistency_check_show(struct device *dev,
if (!ldev_info)
return -ENXIO;
ldev_num = ldev_info->ldev_num;
- status = myrs_get_ldev_info(cs, ldev_num, ldev_info);
+ myrs_get_ldev_info(cs, ldev_num, ldev_info);
if (ldev_info->cc_active)
return snprintf(buf, 32, "checking block %zu of %zu\n",
(size_t)ldev_info->cc_lba,
@@ -1981,14 +1980,13 @@ myrs_get_resync(struct device *dev)
struct myrs_hba *cs = shost_priv(sdev->host);
struct myrs_ldev_info *ldev_info = sdev->hostdata;
u64 percent_complete = 0;
- u8 status;
if (sdev->channel < cs->ctlr_info->physchan_present || !ldev_info)
return;
if (ldev_info->rbld_active) {
unsigned short ldev_num = ldev_info->ldev_num;
- status = myrs_get_ldev_info(cs, ldev_num, ldev_info);
+ myrs_get_ldev_info(cs, ldev_num, ldev_info);
percent_complete = ldev_info->rbld_lba * 100;
do_div(percent_complete, ldev_info->cfg_devsize);
}
--
2.27.0
next prev parent reply other threads:[~2021-03-17 8:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 8:56 [PATCH 00/18] [Set 3] Rid W=1 warnings in SCSI Lee Jones
2021-03-17 8:56 ` [PATCH 01/18] scsi: aic94xx: aic94xx_dump: Remove code that has been unused for at least 13 years Lee Jones
2021-03-17 8:56 ` [PATCH 02/18] scsi: mpt3sas: mpt3sas_scs: Move a little data from the stack onto the heap Lee Jones
2021-03-17 8:56 ` [PATCH 03/18] scsi: bfa: bfa_fcs_lport: Move a large struct " Lee Jones
2021-03-17 8:56 ` [PATCH 04/18] scsi: esas2r: esas2r_log: Supply __printf(x, y) formatting for esas2r_log_master() Lee Jones
2021-03-17 8:56 ` [PATCH 05/18] scsi: BusLogic: Supply __printf(x, y) formatting for blogic_msg() Lee Jones
2021-03-17 8:56 ` [PATCH 06/18] scsi: nsp32: Supply __printf(x, y) formatting for nsp32_message() Lee Jones
2021-03-17 8:56 ` [PATCH 07/18] scsi: initio: Remove unused variable 'prev' Lee Jones
2021-03-17 8:56 ` [PATCH 08/18] scsi: a100u2w: Remove unused variable 'bios_phys' Lee Jones
2021-03-17 8:56 ` Lee Jones [this message]
2021-03-17 8:56 ` [PATCH 10/18] scsi: 3w-xxxx: Remove 2 unused variables 'response_que_value' and 'tw_dev' Lee Jones
2021-03-17 8:56 ` [PATCH 11/18] scsi: 3w-9xxx: Remove a few set but unused variables Lee Jones
2021-03-17 8:56 ` [PATCH 12/18] scsi: 3w-sas: Remove unused variables 'sglist' and 'tw_dev' Lee Jones
2021-03-17 8:56 ` [PATCH 13/18] scsi: nsp32: Remove or exclude unused variables Lee Jones
2021-03-17 8:56 ` [PATCH 14/18] scsi: FlashPoint: Remove unused variable 'TID' from 'FlashPoint_AbortCCB()' Lee Jones
2021-03-17 8:56 ` [PATCH 15/18] scsi: sim710: Remove unused variable 'err' from sim710_init() Lee Jones
2021-03-17 8:56 ` [PATCH 16/18] scsi: isci: port: Make local function 'port_state_name()' static Lee Jones
2021-03-17 8:57 ` [PATCH 17/18] scsi: isci: remote_device: Make local function isci_remote_device_wait_for_resume_from_abort() static Lee Jones
2021-03-17 8:57 ` [PATCH 18/18] scsi: nsp32: Correct expected types in debug print formatting Lee Jones
2021-03-17 9:05 ` [PATCH 00/18] [Set 3] Rid W=1 warnings in SCSI Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210317085701.2891231-10-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=hare@kernel.org \
--cc=hare@suse.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lnz@dandelion.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).