linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org,
	Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org
Subject: [PATCH 30/36] scsi: isci: remote_node_table: Provide some missing params and remove others
Date: Wed, 17 Mar 2021 09:12:24 +0000	[thread overview]
Message-ID: <20210317091230.2912389-31-lee.jones@linaro.org> (raw)
In-Reply-To: <20210317091230.2912389-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/scsi/isci/remote_node_table.c:113: warning: Function parameter or member 'group_table_index' not described in 'sci_remote_node_table_clear_group_index'
 drivers/scsi/isci/remote_node_table.c:113: warning: Excess function parameter 'set_index' description in 'sci_remote_node_table_clear_group_index'
 drivers/scsi/isci/remote_node_table.c:262: warning: Function parameter or member 'group_index' not described in 'sci_remote_node_table_set_group'
 drivers/scsi/isci/remote_node_table.c:383: warning: Function parameter or member 'group_table_index' not described in 'sci_remote_node_table_allocate_single_remote_node'
 drivers/scsi/isci/remote_node_table.c:383: warning: Excess function parameter 'table_index' description in 'sci_remote_node_table_allocate_single_remote_node'
 drivers/scsi/isci/remote_node_table.c:516: warning: Function parameter or member 'remote_node_index' not described in 'sci_remote_node_table_release_single_remote_node'
 drivers/scsi/isci/remote_node_table.c:562: warning: Function parameter or member 'remote_node_index' not described in 'sci_remote_node_table_release_triple_remote_node'
 drivers/scsi/isci/remote_node_table.c:588: warning: Function parameter or member 'remote_node_index' not described in 'sci_remote_node_table_release_remote_node_index'

Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/scsi/isci/remote_node_table.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/scsi/isci/remote_node_table.c b/drivers/scsi/isci/remote_node_table.c
index 1036ab936626e..1bcaf528c1c99 100644
--- a/drivers/scsi/isci/remote_node_table.c
+++ b/drivers/scsi/isci/remote_node_table.c
@@ -99,7 +99,7 @@ static u32 sci_remote_node_table_get_group_index(
  * sci_remote_node_table_clear_group_index()
  * @remote_node_table: This the remote node table in which to clear the
  *    selector.
- * @set_index: This is the remote node selector in which the change will be
+ * @group_table_index: This is the remote node selector in which the change will be
  *    made.
  * @group_index: This is the bit index in the table to be modified.
  *
@@ -250,9 +250,8 @@ static void sci_remote_node_table_clear_group(
 	remote_node_table->available_remote_nodes[dword_location] = dword_value;
 }
 
-/**
+/*
  * sci_remote_node_table_set_group()
- * @remote_node_table:
  *
  * THis method sets an entire remote node group in the remote node table.
  */
@@ -366,7 +365,7 @@ void sci_remote_node_table_initialize(
  * sci_remote_node_table_allocate_single_remote_node()
  * @remote_node_table: The remote node table from which to allocate a
  *    remote node.
- * @table_index: The group index that is to be used for the search.
+ * @group_table_index: The group index that is to be used for the search.
  *
  * This method will allocate a single RNi from the remote node table.  The
  * table index will determine from which remote node group table to search.
@@ -426,7 +425,7 @@ static u16 sci_remote_node_table_allocate_single_remote_node(
  * sci_remote_node_table_allocate_triple_remote_node()
  * @remote_node_table: This is the remote node table from which to allocate the
  *    remote node entries.
- * @group_table_index: THis is the group table index which must equal two (2)
+ * @group_table_index: This is the group table index which must equal two (2)
  *    for this operation.
  *
  * This method will allocate three consecutive remote node context entries. If
@@ -506,7 +505,7 @@ u16 sci_remote_node_table_allocate_remote_node(
  * sci_remote_node_table_release_single_remote_node()
  * @remote_node_table: This is the remote node table from which the remote node
  *    release is to take place.
- *
+ * @remote_node_index: This is the remote node index that is being released.
  * This method will free a single remote node index back to the remote node
  * table.  This routine will update the remote node groups
  */
@@ -552,6 +551,7 @@ static void sci_remote_node_table_release_single_remote_node(
  * sci_remote_node_table_release_triple_remote_node()
  * @remote_node_table: This is the remote node table to which the remote node
  *    index is to be freed.
+ * @remote_node_index: This is the remote node index that is being released.
  *
  * This method will release a group of three consecutive remote nodes back to
  * the free remote nodes.
@@ -577,6 +577,7 @@ static void sci_remote_node_table_release_triple_remote_node(
  *    to be freed.
  * @remote_node_count: This is the count of consecutive remote nodes that are
  *    to be freed.
+ * @remote_node_index: This is the remote node index that is being released.
  *
  * This method will release the remote node index back into the remote node
  * table free pool.
-- 
2.27.0


  parent reply	other threads:[~2021-03-17  9:14 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17  9:11 [PATCH 00/36] [Set 4] Rid W=1 warnings in SCSI Lee Jones
2021-03-17  9:11 ` [PATCH 01/36] scsi: myrb: Demote non-conformant kernel-doc headers and fix others Lee Jones
2021-03-17  9:11 ` [PATCH 02/36] scsi: ipr: Fix incorrect function names in their headers Lee Jones
2021-03-17  9:11 ` [PATCH 03/36] scsi: mvumi: Fix formatting and doc-rot issues Lee Jones
2021-03-17  9:11 ` [PATCH 04/36] scsi: sd_zbc: Place function name into header Lee Jones
2021-03-17  9:11 ` [PATCH 05/36] scsi: pmcraid: Fix a whole host of kernel-doc issues Lee Jones
2021-03-17  9:12 ` [PATCH 06/36] scsi: sd: Fix function name in header Lee Jones
2021-03-17  9:12 ` [PATCH 07/36] scsi: aic94xx: aic94xx_dump: Correct misspelling of function asd_dump_seq_state() Lee Jones
2021-03-17  9:12 ` [PATCH 08/36] scsi: be2iscsi: be_main: Ensure function follows directly after its header Lee Jones
2021-03-17  9:12 ` [PATCH 09/36] scsi: dc395x: Fix some function param descriptions Lee Jones
2021-03-17  9:12 ` [PATCH 10/36] scsi: initio: Fix a few kernel-doc misdemeanours Lee Jones
2021-03-17  9:12 ` [PATCH 11/36] scsi: a100u2w: Fix some misnaming and formatting issues Lee Jones
2021-03-17  9:12 ` [PATCH 12/36] scsi: myrs: Add missing ':' to make the kernel-doc checker happy Lee Jones
2021-03-17  9:12 ` [PATCH 13/36] scsi: pmcraid: Correct function name pmcraid_show_adapter_id() in header Lee Jones
2021-03-17  9:12 ` [PATCH 14/36] scsi: mpt3sas: mpt3sas_scs: Fix a few kernel-doc issues Lee Jones
2021-03-17  9:12 ` [PATCH 15/36] scsi: be2iscsi: be_main: Demote incomplete/non-conformant kernel-doc header Lee Jones
2021-03-17  9:12 ` [PATCH 16/36] scsi: isci: phy: Fix a few different kernel-doc related issues Lee Jones
2021-03-17  9:12 ` [PATCH 17/36] scsi: fnic: fnic_scsi: Demote non-conformant kernel-doc headers Lee Jones
2021-03-17  9:12 ` [PATCH 18/36] scsi: fnic: fnic_fcs: Kernel-doc headers must contain the function name Lee Jones
2021-03-17  9:12 ` [PATCH 19/36] scsi: isci: phy: Provide function name and demote non-conforming header Lee Jones
2021-03-17  9:12 ` [PATCH 20/36] scsi: isci: request: Fix a myriad of kernel-doc issues Lee Jones
2021-03-17  9:12 ` [PATCH 21/36] scsi: isci: host: Fix bunch of kernel-doc related issues Lee Jones
2021-03-17  9:12 ` [PATCH 22/36] scsi: isci: task: Demote non-conformant header and remove superfluous param Lee Jones
2021-03-17  9:12 ` [PATCH 23/36] scsi: isci: remote_node_table: Fix a bunch of kernel-doc misdemeanours Lee Jones
2021-03-17  9:12 ` [PATCH 24/36] scsi: isci: remote_node_context: Fix one function header and demote a couple more Lee Jones
2021-03-17  9:12 ` [PATCH 25/36] scsi: isci: port_config: Fix a bunch of doc-rot and demote abuses Lee Jones
2021-03-17  9:12 ` [PATCH 26/36] scsi: isci: remote_device: Fix a bunch of doc-rot issues Lee Jones
2021-03-17  9:12 ` [PATCH 27/36] scsi: isci: request: Fix doc-rot issue relating to 'ireq' param Lee Jones
2021-03-17  9:12 ` [PATCH 28/36] scsi: isci: port: Fix a bunch of kernel-doc issues Lee Jones
2021-03-17  9:12 ` [PATCH 29/36] scsi: isci: remote_node_context: Demote kernel-doc abuse Lee Jones
2021-03-17  9:12 ` Lee Jones [this message]
2021-03-17  9:12 ` [PATCH 31/36] scsi: cxlflash: main: Fix a little do-rot Lee Jones
2021-03-17  9:12 ` [PATCH 32/36] scsi: cxlflash: superpipe: Fix a few misnaming issues Lee Jones
2021-03-17  9:12 ` [PATCH 33/36] scsi: ibmvscsi: Fix a bunch of kernel-doc related issues Lee Jones
2021-03-17  9:12 ` [PATCH 34/36] scsi: ibmvscsi: ibmvfc: Fix a bunch of misdocumentation Lee Jones
2021-03-17  9:12 ` [PATCH 35/36] scsi: ibmvscsi_tgt: ibmvscsi_tgt: Remove duplicate section 'NOTE' Lee Jones
2021-03-17  9:12 ` [PATCH 36/36] scsi: cxlflash: vlun: Fix some misnaming related doc-rot Lee Jones
2021-03-19  3:41 ` [PATCH 00/36] [Set 4] Rid W=1 warnings in SCSI Martin K. Petersen
2021-03-19  8:10   ` Lee Jones
2021-03-25  3:53 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210317091230.2912389-31-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=artur.paszkiewicz@intel.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).