From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Tiezhu Yang <yangtiezhu@loongson.cn>,
linux-mips@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH] MIPS/bpf: Enable bpf_probe_read{, str}() on MIPS again
Date: Thu, 18 Mar 2021 00:08:08 +0100 [thread overview]
Message-ID: <20210317230808.GA22680@alpha.franken.de> (raw)
In-Reply-To: <6b239565-8fbb-d183-6a4d-13fc90af3e27@iogearbox.net>
On Wed, Mar 17, 2021 at 11:18:48PM +0100, Daniel Borkmann wrote:
> On 3/17/21 8:15 AM, Tiezhu Yang wrote:
> > After commit 0ebeea8ca8a4 ("bpf: Restrict bpf_probe_read{, str}() only to
> > archs where they work"), bpf_probe_read{, str}() functions were not longer
> > available on MIPS, so there exists some errors when running bpf program:
> >
> > root@linux:/home/loongson/bcc# python examples/tracing/task_switch.py
> > bpf: Failed to load program: Invalid argument
> > [...]
> > 11: (85) call bpf_probe_read#4
> > unknown func bpf_probe_read#4
> > [...]
> > Exception: Failed to load BPF program count_sched: Invalid argument
> >
> > So select ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE in arch/mips/Kconfig,
> > otherwise the bpf old helper bpf_probe_read() will not be available.
> >
> > This is similar with the commit d195b1d1d1196 ("powerpc/bpf: Enable
> > bpf_probe_read{, str}() on powerpc again").
> >
> > Fixes: 0ebeea8ca8a4 ("bpf: Restrict bpf_probe_read{, str}() only to archs where they work")
> > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>
> Thomas, I presume you pick this up via mips tree (with typos fixed)? Or do you
> want us to route the fix via bpf with your ACK? (I'm fine either way.)
I'll take it via mips tree.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2021-03-17 23:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 7:15 [PATCH] MIPS/bpf: Enable bpf_probe_read{, str}() on MIPS again Tiezhu Yang
2021-03-17 9:59 ` Sergei Shtylyov
2021-03-17 22:18 ` Daniel Borkmann
2021-03-17 23:08 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210317230808.GA22680@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).