From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D10DCC433E0 for ; Thu, 18 Mar 2021 16:51:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A53F464ED2 for ; Thu, 18 Mar 2021 16:51:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232240AbhCRQuf (ORCPT ); Thu, 18 Mar 2021 12:50:35 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:44894 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232088AbhCRQu2 (ORCPT ); Thu, 18 Mar 2021 12:50:28 -0400 Received: from mail-ed1-f69.google.com ([209.85.208.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lMvqt-0008Fq-LW for linux-kernel@vger.kernel.org; Thu, 18 Mar 2021 16:50:27 +0000 Received: by mail-ed1-f69.google.com with SMTP id w18so18696878edu.5 for ; Thu, 18 Mar 2021 09:50:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nI/HK/aZiw2vFmpQW7WXqgLR8ZA4MRBAnT3xFXPYJvY=; b=dTR731/4xRRlItVMcp0btkv/VGe6YgH9oOmrdcghtkDnfaMF2sRJrlrb99SObjIdSV kXz0sVkCSGp0QlngLyyI5spDyEJ4+X7Llju+MJoZek0iLb4mHTvkcDoubpjOUKqB7fQd T8O+Fyd+RRFGLki2b/7+Z6H055v/uoHboZaNtG3Tn1t0dwY7Llt+O8PDWOGKHx54Xidk sRHzUAfFx5FG3rKRr1l8bkfhRW37T4ppLJvNJ5A+VNMluE/Gh9ZN3F0Tl6Hzi8QxXxs0 QphF+DbHWs+LsUT8oS3jJgzyt0wQWudpRAu5dNWJc4f9QpAEKrwRPuq9Q+xZwjIBmu9U beLw== X-Gm-Message-State: AOAM5307h4oHCXoIqvU5jfyA8scqWm+ONE571BsxtdTKIp9E/3azGtJ/ PdNUvcgx7mlU/MpZbpOs810SkhCWm4TePlhLDaUIMXRKYshUEbZrd67GVWdoOSH+prWFoI+FPZT yR6TyK204LIdLGOj3SET2+BsjAL+Wo+ThRD/CfAZ/GQ== X-Received: by 2002:a17:907:7785:: with SMTP id ky5mr30156328ejc.133.1616086227304; Thu, 18 Mar 2021 09:50:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyyoS4Ti12fWMuNJAcdVQigMxK1LzeM53WUAy30CtNftdFq6ca6eUEX5JvR4oEtxdOB/4ElZw== X-Received: by 2002:a17:907:7785:: with SMTP id ky5mr30156316ejc.133.1616086227110; Thu, 18 Mar 2021 09:50:27 -0700 (PDT) Received: from gmail.com (ip5f5af0a0.dynamic.kabel-deutschland.de. [95.90.240.160]) by smtp.gmail.com with ESMTPSA id s20sm2279251ejj.38.2021.03.18.09.50.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 09:50:26 -0700 (PDT) Date: Thu, 18 Mar 2021 17:50:25 +0100 From: Christian Brauner To: Al Viro Cc: Matthew Wilcox , Xiaofeng Cao , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Xiaofeng Cao Subject: Re: [PATCH] fs/dcache: fix typos and sentence disorder Message-ID: <20210318165025.qquejvrcgwfyrrfg@gmail.com> References: <20210318143153.13455-1-caoxiaofeng@yulong.com> <20210318150020.GP3420@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 18, 2021 at 04:35:34PM +0000, Al Viro wrote: > On Thu, Mar 18, 2021 at 03:00:20PM +0000, Matthew Wilcox wrote: > > On Thu, Mar 18, 2021 at 10:31:53PM +0800, Xiaofeng Cao wrote: > > > change 'sould' to 'should' > > > change 'colocated' to 'collocated' > > > > uh. collocated is incorrect. colocated is correct. > > https://www.merriam-webster.com/dictionary/colocate > > https://www.merriam-webster.com/dictionary/collocate > > A bit more condensed variant: these two are both derived from > con- + loco, but have different meanings - > colocated: occupying the same place > collocated: sitting next to each other > > In this case it's very much the former - the point of comment is that > the fields in question share the same memory location, but we are > guaranteed that any dentry we find in the alias list of an inode will > have that location used for ->i_dentry. > > "co-located" would probably work better there. > > PS: history of that word pair is amusing. Both are (English) past participles, > of co-locate and collocate resp. The former had the (Latin) prefix applied in > English to borrowing from Latin (co-locate < locate < locatus) , the latter > is straight borrowing (collocate < collocatus). Incidentally, in both cases > the borrowed form had already been a past participle (of loco and > colloco) resp. And colloco had the same prefix (com-/con-/co-) applied > in Latin, with regular assimilation of -nl- to -ll-. But at that stage > the meaning of the verb had been closer to "put in place" than to > "be in place", so that gave "put next to each other" instead of "share > the place". Shift towards "be found next to each other" happened long after > the prefix had been applied... (Flashback to my latin exams. The only thing that is missing is complete confusion about nested subordinate clauses... ;))