From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB7D2C433E6 for ; Thu, 18 Mar 2021 20:37:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8594564F53 for ; Thu, 18 Mar 2021 20:37:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231634AbhCRUhV (ORCPT ); Thu, 18 Mar 2021 16:37:21 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:48580 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233084AbhCRUhN (ORCPT ); Thu, 18 Mar 2021 16:37:13 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 887E31C0B7C; Thu, 18 Mar 2021 21:37:12 +0100 (CET) Date: Thu, 18 Mar 2021 21:37:12 +0100 From: Pavel Machek To: Rahul Tanwar Cc: Arnd Bergmann , "linux-leds@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Adam Borowski , "Rafael J. Wysocki" , John Crispin , Hauke Mehrtens , Cheol Yong Kim , Qiming Wu Subject: Re: [PATCH 1/1] leds: lgm: Improve Kconfig help Message-ID: <20210318203711.GA8429@amd> References: <8ae0456a08ef1a2491fd382b273ff7259e6fcbd0.1615969806.git.rtanwar@maxlinear.com> <20210318075552.GA2331@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wac7ysb48OaltWcw" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wac7ysb48OaltWcw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > help > > > - Parallel to serial conversion, which is also called SSO > > > controller, > > > - can drive external shift register for LED outputs. > > > - This enables LED support for Serial Shift Output controller(SSO). > > > + This option enables support for LEDs connected to GPIO lines on > > > + Lightning Mountain(LGM) SoC. These LEDs are driven by a Serial > > > + Shift Output(SSO) controller. The driver supports hardware > >=20 > > What is Lightning Mountain? The codename is not widely known. Where > > can we find that hardware? Notebooks? Phones? Only some development > > boards? > >=20 >=20 > Lightning Mountain is generically a network processor with a primary=20 > targeted application as Gateway SoC. It has already been added as a=20 > valid Intel Atom processor variant in=20 > arch/x86/include/asm/intel-family.h as below: Yep, but Kconfig users are not going to read header files. If the SoC is not shipping in any products, state so. > > > * > > > - * Copyright (c) 2020 Intel Corporation. > > > + * Copyright (c) 2021 MaxLinear, Inc. > > > */ > > > > >=20 > > I don't think you can do that, and I don't think you should be doing > > it in the same patch. >=20 > Well noted. Will revert it back now and update later in a separate=20 > patch. Thanks. Don't. You can't update copyright like that. Pavel --=20 http://www.livejournal.com/~pavelmachek --wac7ysb48OaltWcw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmBTufcACgkQMOfwapXb+vIi6wCgh+jfNVDq4t4Lp0ipP1ajsy82 O+0AniEb6gxxkylOv0nwB3vg7woAnh13 =HWCd -----END PGP SIGNATURE----- --wac7ysb48OaltWcw--