From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Wong Vee Khee <vee.khee.wong@intel.com>,
Andrew Lunn <andrew@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Calvin Johnson <calvin.johnson@oss.nxp.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Voon Weifeng <weifeng.voon@intel.com>,
Ong Boon Leong <boon.leong.ong@intel.com>
Subject: Re: [PATCH net V2 1/1] net: phy: fix invalid phy id when probe using C22
Date: Fri, 19 Mar 2021 08:56:28 +0000 [thread overview]
Message-ID: <20210319085628.GT1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <3f7f68d0-6bbd-baa0-5de8-1e8a0a50a04d@gmail.com>
On Fri, Mar 19, 2021 at 08:40:45AM +0100, Heiner Kallweit wrote:
> Is there a specific reason why c22 is probed first? Reversing the order
> would solve the issue we speak about here.
> c45-probing of c22-only PHY's shouldn't return false positives
> (at least at a first glance).
That would likely cause problems for the I2f MDIO driver, since a
C45 read is indistinguishable from a C22 write on the I2C bus.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-03-19 8:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 9:09 [PATCH net V2 1/1] net: phy: fix invalid phy id when probe using C22 Wong Vee Khee
2021-03-18 13:25 ` Heiner Kallweit
2021-03-18 16:02 ` Florian Fainelli
2021-03-18 16:21 ` Russell King - ARM Linux admin
2021-03-18 16:48 ` Heiner Kallweit
2021-03-18 18:14 ` Greg KH
2021-03-18 18:58 ` Florian Fainelli
2021-03-19 7:40 ` Heiner Kallweit
2021-03-19 8:56 ` Russell King - ARM Linux admin [this message]
2021-03-22 12:39 ` Wong, Vee Khee
2021-03-26 1:57 ` [net] c0da0048be: WARNING:at_net/core/devlink.c:#devlink_port_type_warn kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319085628.GT1463@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=boon.leong.ong@intel.com \
--cc=calvin.johnson@oss.nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jeremy.linton@arm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vee.khee.wong@intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).