From: Christoph Hellwig <hch@lst.de>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Christoph Hellwig <hch@lst.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Tomasz Figa <tfiga@chromium.org>,
Sergey Senozhatsky <senozhatsky@google.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
"list@263.net:IOMMU DRIVERS <iommu@lists.linux-foundation.org>,
Joerg Roedel <joro@8bytes.org>,"
<iommu@lists.linux-foundation.org>,
Robin Murphy <robin.murphy@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH v4 6/6] media: uvcvideo: Use dma_alloc_noncontiguous API
Date: Fri, 19 Mar 2021 14:10:11 +0100 [thread overview]
Message-ID: <20210319131011.GA3372@lst.de> (raw)
In-Reply-To: <CANiDSCunsYwjB=PYYJnpaEnB3pg7No40gOE1jTVwxJkJJpE2Nw@mail.gmail.com>
On Fri, Mar 19, 2021 at 02:05:21PM +0100, Ricardo Ribalda wrote:
> > + uvc_urb->sgt,
> > + uvc_stream_dir(uvc_urb->stream));
> > + return usb_submit_urb(uvc_urb->urb, GFP_KERNEL);
> > +}
>
> We should have mem_flags instead of GFP_KERNEL here
>
>
> Is it too late to fix it in your tree? Do I need to send a patch to fix it?
As far as I know we don't have anything that has pulled in the tree yet,
so I can just fold the fix in.
next prev parent reply other threads:[~2021-03-19 13:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 23:55 [PATCH v4 6/6] media: uvcvideo: Use dma_alloc_noncontiguous API Ricardo Ribalda
2021-03-15 7:30 ` Ricardo Ribalda
2021-03-15 7:34 ` Christoph Hellwig
2021-03-15 7:35 ` Ricardo Ribalda
2021-03-15 10:04 ` Christoph Hellwig
2021-03-19 13:05 ` Ricardo Ribalda
2021-03-19 13:10 ` Christoph Hellwig [this message]
2021-03-19 13:10 ` Ricardo Ribalda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319131011.GA3372@lst.de \
--to=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
--cc=robin.murphy@arm.com \
--cc=senozhatsky@google.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).