From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AFADC433E5 for ; Fri, 19 Mar 2021 15:58:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1133C6196D for ; Fri, 19 Mar 2021 15:58:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230442AbhCSP5c (ORCPT ); Fri, 19 Mar 2021 11:57:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:58460 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbhCSP5N (ORCPT ); Fri, 19 Mar 2021 11:57:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 707726195F; Fri, 19 Mar 2021 15:57:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616169432; bh=B5EKdJdy44dikwwP4V0T3aMuGft8nFhye4jvFnctszU=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=ooI6ryJvWBJHvlBAYaqPZwmSJm6eQzuhpSMgn3YsYQFYjHhmBm6GW8nb9q6x7fM8P WMWHiZypoelXgeKP+AADBVVSDohdED9F0lTuvsamZmATGQcafStX/mDdJcClNfTwge GUYfHAYgvFt7Zm4qfY8HvABhs8BupN8TK7lbjomvyi0GNHDvVqKjRRRg5OgSbjAkVD z/6KHEsSGtP2PYHSY6gDpZ+USfOP8NKzAGj35Ta+nPGyG3E9O7e50VciUpAKBLbi7Z ffRsLmDBSPblq2Tnd5YbFoAbUo5moay0/933cysisOSa5g5Ta3gqtvz+D7lmzli3B0 +Z6YQ6zbxruPg== Date: Fri, 19 Mar 2021 10:57:11 -0500 From: Bjorn Helgaas To: Leon Romanovsky Cc: "Enrico Weigelt, metux IT consult" , Alex Williamson , Amey Narkhede , raphael.norwitz@nutanix.com, linux-pci@vger.kernel.org, bhelgaas@google.com, linux-kernel@vger.kernel.org, alay.shah@nutanix.com, suresh.gumpula@nutanix.com, shyam.rajendran@nutanix.com, felipe@nutanix.com Subject: Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism Message-ID: <20210319155711.GA234744@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 19, 2021 at 02:59:47PM +0200, Leon Romanovsky wrote: > On Thu, Mar 18, 2021 at 07:34:56PM +0100, Enrico Weigelt, metux IT consult wrote: > > On 18.03.21 18:22, Leon Romanovsky wrote: > > > > > Which email client do you use? Your responses are grouped as > > > one huge block without any chance to respond to you on specific > > > point or answer to your question. > > > > I'm reading this thread in Tbird, and threading / quoting all > > looks nice. > > I'm not talking about threading or quoting but about response > itself. See it here > https://lore.kernel.org/lkml/20210318103935.2ec32302@omen.home.shazbot.org/ > Alex's response is one big chunk without any separations to > paragraphs. Don't make this harder than it needs to be. I think it's totally acceptable to just split Alex's text where you need to respond. For example, Alex wrote this: vfio-pci uses the internal kernel API, ie. the variants of pci_reset_function(), which is the same interface used by the existing sysfs reset mechanism. This proposed configuration of the reset method would affect any driver using that same core infrastructure and from my perspective that's really the goal. ... If I wanted to respond to the first sentence, I would just do this: aw> vfio-pci uses the internal kernel API, ie. the variants of aw> pci_reset_function(), which is the same interface used by the existing aw> sysfs reset mechanism. I would write my response to the above here. The rest of the quote continues on below. If the rest of Alex's message isn't relevant to my response, I would remove it completely. aw> This proposed configuration of the reset method aw> would affect any driver using that same core infrastructure and from my aw> perspective that's really the goal. ... Bjorn