From: Borislav Petkov <bp@alien8.de>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Jarkko Sakkinen <jarkko@kernel.org>,
Kai Huang <kai.huang@intel.com>,
x86@kernel.org, linux-sgx@vger.kernel.org,
dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/sgx: Avoid returning NULL in __sgx_alloc_epc_page()
Date: Fri, 19 Mar 2021 17:09:20 +0100 [thread overview]
Message-ID: <20210319160920.GM6251@zn.tnic> (raw)
In-Reply-To: <eea239f3-720d-0f53-6c8a-85050f44be53@intel.com>
On Fri, Mar 19, 2021 at 08:59:46AM -0700, Dave Hansen wrote:
> It's probably best to squash my patch in. The uninitialized value could
> *theoretically* cause the search to start at the wrong node and then end
> before every node has been visited. That could cause premature
> allocation failures.
>
> But, I seriously doubt anyone will notice either way.
Yeah, I think too that we should be on the safe side, just in case.
Lemme redo the branch with the new changes and test.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-03-19 16:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 4:06 [PATCH] x86/sgx: Avoid returning NULL in __sgx_alloc_epc_page() Kai Huang
2021-03-19 5:42 ` Jarkko Sakkinen
2021-03-19 8:45 ` Borislav Petkov
2021-03-19 9:01 ` Kai Huang
2021-03-19 9:12 ` Kai Huang
2021-03-19 14:50 ` Jarkko Sakkinen
2021-03-19 14:59 ` Borislav Petkov
2021-03-19 15:22 ` Jarkko Sakkinen
2021-03-19 15:52 ` Borislav Petkov
2021-03-19 15:59 ` Dave Hansen
2021-03-19 16:09 ` Borislav Petkov [this message]
2021-03-19 14:49 ` Jarkko Sakkinen
2021-03-19 18:45 ` [tip: x86/sgx] x86/sgx: Add a basic NUMA allocation scheme to sgx_alloc_epc_page() tip-bot2 for Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319160920.GM6251@zn.tnic \
--to=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=kai.huang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).