From: Michael Zaidman <michael.zaidman@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>, Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-i2c@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Michael Zaidman <michael.zaidman@gmail.com>
Subject: Re: [PATCH] HID: ft260: fix an error message in ft260_i2c_write_read()
Date: Fri, 19 Mar 2021 18:56:05 +0200 [thread overview]
Message-ID: <20210319165605.GB1940@michael-VirtualBox> (raw)
In-Reply-To: <nycvar.YFH.7.76.2103191426350.12405@cbobk.fhfr.pm>
On Fri, Mar 19, 2021 at 02:26:43PM +0100, Jiri Kosina wrote:
> On Thu, 18 Mar 2021, Dan Carpenter wrote:
>
> > The "len" variable is uninitialize.
> >
> > Fixes: 6a82582d9fa4 ("HID: ft260: add usb hid to i2c host bridge driver")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > drivers/hid/hid-ft260.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c
> > index 047aa85a7c83..a5751607ce24 100644
> > --- a/drivers/hid/hid-ft260.c
> > +++ b/drivers/hid/hid-ft260.c
> > @@ -512,7 +512,8 @@ static int ft260_i2c_write_read(struct ft260_device *dev, struct i2c_msg *msgs)
> > struct hid_device *hdev = dev->hdev;
> >
> > if (msgs[0].len > 2) {
> > - hid_err(hdev, "%s: unsupported wr len: %d\n", __func__, len);
> > + hid_err(hdev, "%s: unsupported wr len: %d\n", __func__,
> > + msgs[0].len);
> > return -EOPNOTSUPP;
> > }
Dan, thanks for that quick fix.
> Applied, thanks Dan.
> --
> Jiri Kosina
Jiri, thank you for applying it.
prev parent reply other threads:[~2021-03-19 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 10:39 [PATCH] HID: ft260: fix an error message in ft260_i2c_write_read() Dan Carpenter
2021-03-19 13:26 ` Jiri Kosina
2021-03-19 16:56 ` Michael Zaidman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319165605.GB1940@michael-VirtualBox \
--to=michael.zaidman@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=jikos@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).