linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user'
@ 2021-03-19 19:10 kernel test robot
  0 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2021-03-19 19:10 UTC (permalink / raw)
  To: Al Viro; +Cc: kbuild-all, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 3514 bytes --]

Hi Al,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   8b12a62a4e3ed4ae99c715034f557eb391d6b196
commit: 808b49da54e640cba5c5c92dee658018a529226b alpha: turn csum_partial_copy_from_user() into csum_and_copy_from_user()
date:   10 months ago
config: alpha-defconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=808b49da54e640cba5c5c92dee658018a529226b
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 808b49da54e640cba5c5c92dee658018a529226b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user' [-Werror=missing-prototypes]
     328 | csum_and_copy_from_user(const void __user *src, void *dst, int len,
         | ^~~~~~~~~~~~~~~~~~~~~~~
   arch/alpha/lib/csum_partial_copy.c:375:1: error: no previous prototype for 'csum_partial_copy_nocheck' [-Werror=missing-prototypes]
     375 | csum_partial_copy_nocheck(const void *src, void *dst, int len, __wsum sum)
         | ^~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +/csum_and_copy_from_user +328 arch/alpha/lib/csum_partial_copy.c

   326	
   327	__wsum
 > 328	csum_and_copy_from_user(const void __user *src, void *dst, int len,
   329				       __wsum sum, int *errp)
   330	{
   331		unsigned long checksum = (__force u32) sum;
   332		unsigned long soff = 7 & (unsigned long) src;
   333		unsigned long doff = 7 & (unsigned long) dst;
   334	
   335		if (len) {
   336			if (!access_ok(src, len)) {
   337				if (errp) *errp = -EFAULT;
   338				memset(dst, 0, len);
   339				return sum;
   340			}
   341			if (!doff) {
   342				if (!soff)
   343					checksum = csum_partial_cfu_aligned(
   344						(const unsigned long __user *) src,
   345						(unsigned long *) dst,
   346						len-8, checksum, errp);
   347				else
   348					checksum = csum_partial_cfu_dest_aligned(
   349						(const unsigned long __user *) src,
   350						(unsigned long *) dst,
   351						soff, len-8, checksum, errp);
   352			} else {
   353				unsigned long partial_dest;
   354				ldq_u(partial_dest, dst);
   355				if (!soff)
   356					checksum = csum_partial_cfu_src_aligned(
   357						(const unsigned long __user *) src,
   358						(unsigned long *) dst,
   359						doff, len-8, checksum,
   360						partial_dest, errp);
   361				else
   362					checksum = csum_partial_cfu_unaligned(
   363						(const unsigned long __user *) src,
   364						(unsigned long *) dst,
   365						soff, doff, len-8, checksum,
   366						partial_dest, errp);
   367			}
   368			checksum = from64to16 (checksum);
   369		}
   370		return (__force __wsum)checksum;
   371	}
   372	EXPORT_SYMBOL(csum_and_copy_from_user);
   373	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 13763 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user'
@ 2021-05-06 14:26 kernel test robot
  0 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2021-05-06 14:26 UTC (permalink / raw)
  To: Al Viro; +Cc: kbuild-all, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 3533 bytes --]

Hi Al,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   8404c9fbc84b741f66cff7d4934a25dd2c344452
commit: 808b49da54e640cba5c5c92dee658018a529226b alpha: turn csum_partial_copy_from_user() into csum_and_copy_from_user()
date:   11 months ago
config: alpha-randconfig-r006-20210506 (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=808b49da54e640cba5c5c92dee658018a529226b
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 808b49da54e640cba5c5c92dee658018a529226b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user' [-Werror=missing-prototypes]
     328 | csum_and_copy_from_user(const void __user *src, void *dst, int len,
         | ^~~~~~~~~~~~~~~~~~~~~~~
   arch/alpha/lib/csum_partial_copy.c:375:1: error: no previous prototype for 'csum_partial_copy_nocheck' [-Werror=missing-prototypes]
     375 | csum_partial_copy_nocheck(const void *src, void *dst, int len, __wsum sum)
         | ^~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +/csum_and_copy_from_user +328 arch/alpha/lib/csum_partial_copy.c

   326	
   327	__wsum
 > 328	csum_and_copy_from_user(const void __user *src, void *dst, int len,
   329				       __wsum sum, int *errp)
   330	{
   331		unsigned long checksum = (__force u32) sum;
   332		unsigned long soff = 7 & (unsigned long) src;
   333		unsigned long doff = 7 & (unsigned long) dst;
   334	
   335		if (len) {
   336			if (!access_ok(src, len)) {
   337				if (errp) *errp = -EFAULT;
   338				memset(dst, 0, len);
   339				return sum;
   340			}
   341			if (!doff) {
   342				if (!soff)
   343					checksum = csum_partial_cfu_aligned(
   344						(const unsigned long __user *) src,
   345						(unsigned long *) dst,
   346						len-8, checksum, errp);
   347				else
   348					checksum = csum_partial_cfu_dest_aligned(
   349						(const unsigned long __user *) src,
   350						(unsigned long *) dst,
   351						soff, len-8, checksum, errp);
   352			} else {
   353				unsigned long partial_dest;
   354				ldq_u(partial_dest, dst);
   355				if (!soff)
   356					checksum = csum_partial_cfu_src_aligned(
   357						(const unsigned long __user *) src,
   358						(unsigned long *) dst,
   359						doff, len-8, checksum,
   360						partial_dest, errp);
   361				else
   362					checksum = csum_partial_cfu_unaligned(
   363						(const unsigned long __user *) src,
   364						(unsigned long *) dst,
   365						soff, doff, len-8, checksum,
   366						partial_dest, errp);
   367			}
   368			checksum = from64to16 (checksum);
   369		}
   370		return (__force __wsum)checksum;
   371	}
   372	EXPORT_SYMBOL(csum_and_copy_from_user);
   373	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27578 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user'
@ 2021-03-19 11:52 kernel test robot
  0 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2021-03-19 11:52 UTC (permalink / raw)
  To: Al Viro; +Cc: kbuild-all, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 3529 bytes --]

Hi Al,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   8b12a62a4e3ed4ae99c715034f557eb391d6b196
commit: 808b49da54e640cba5c5c92dee658018a529226b alpha: turn csum_partial_copy_from_user() into csum_and_copy_from_user()
date:   10 months ago
config: alpha-randconfig-r013-20210319 (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=808b49da54e640cba5c5c92dee658018a529226b
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 808b49da54e640cba5c5c92dee658018a529226b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user' [-Werror=missing-prototypes]
     328 | csum_and_copy_from_user(const void __user *src, void *dst, int len,
         | ^~~~~~~~~~~~~~~~~~~~~~~
   arch/alpha/lib/csum_partial_copy.c:375:1: error: no previous prototype for 'csum_partial_copy_nocheck' [-Werror=missing-prototypes]
     375 | csum_partial_copy_nocheck(const void *src, void *dst, int len, __wsum sum)
         | ^~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +/csum_and_copy_from_user +328 arch/alpha/lib/csum_partial_copy.c

   326	
   327	__wsum
 > 328	csum_and_copy_from_user(const void __user *src, void *dst, int len,
   329				       __wsum sum, int *errp)
   330	{
   331		unsigned long checksum = (__force u32) sum;
   332		unsigned long soff = 7 & (unsigned long) src;
   333		unsigned long doff = 7 & (unsigned long) dst;
   334	
   335		if (len) {
   336			if (!access_ok(src, len)) {
   337				if (errp) *errp = -EFAULT;
   338				memset(dst, 0, len);
   339				return sum;
   340			}
   341			if (!doff) {
   342				if (!soff)
   343					checksum = csum_partial_cfu_aligned(
   344						(const unsigned long __user *) src,
   345						(unsigned long *) dst,
   346						len-8, checksum, errp);
   347				else
   348					checksum = csum_partial_cfu_dest_aligned(
   349						(const unsigned long __user *) src,
   350						(unsigned long *) dst,
   351						soff, len-8, checksum, errp);
   352			} else {
   353				unsigned long partial_dest;
   354				ldq_u(partial_dest, dst);
   355				if (!soff)
   356					checksum = csum_partial_cfu_src_aligned(
   357						(const unsigned long __user *) src,
   358						(unsigned long *) dst,
   359						doff, len-8, checksum,
   360						partial_dest, errp);
   361				else
   362					checksum = csum_partial_cfu_unaligned(
   363						(const unsigned long __user *) src,
   364						(unsigned long *) dst,
   365						soff, doff, len-8, checksum,
   366						partial_dest, errp);
   367			}
   368			checksum = from64to16 (checksum);
   369		}
   370		return (__force __wsum)checksum;
   371	}
   372	EXPORT_SYMBOL(csum_and_copy_from_user);
   373	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32719 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user'
  2021-02-12  2:52 ` Randy Dunlap
@ 2021-02-14 22:59   ` Al Viro
  0 siblings, 0 replies; 7+ messages in thread
From: Al Viro @ 2021-02-14 22:59 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: kernel test robot, kbuild-all, linux-kernel

On Thu, Feb 11, 2021 at 06:52:36PM -0800, Randy Dunlap wrote:
> >>> arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user' [-Werror=missing-prototypes]
> >      328 | csum_and_copy_from_user(const void __user *src, void *dst, int len,
> >          | ^~~~~~~~~~~~~~~~~~~~~~~
> >    arch/alpha/lib/csum_partial_copy.c:375:1: error: no previous prototype for 'csum_partial_copy_nocheck' [-Werror=missing-prototypes]
> >      375 | csum_partial_copy_nocheck(const void *src, void *dst, int len, __wsum sum)
> >          | ^~~~~~~~~~~~~~~~~~~~~~~~~
> >    cc1: all warnings being treated as errors
> 
> I can't reproduce this (wrong version of gcc) but it looks like adding
> #include <asm/checksum.h>
> to arch/alpha/lib/csum_partial_copy.c should fix the warnings.

I'd rather go with net/checksum.h; converting all includes outside of
net/checksum.h itself would have to wait, but let's not breed more of
those without a good reason...

^ permalink raw reply	[flat|nested] 7+ messages in thread

* arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user'
@ 2021-02-12  8:33 kernel test robot
  0 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2021-02-12  8:33 UTC (permalink / raw)
  To: Al Viro; +Cc: kbuild-all, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 3528 bytes --]

Hi Al,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   dcc0b49040c70ad827a7f3d58a21b01fdb14e749
commit: 808b49da54e640cba5c5c92dee658018a529226b alpha: turn csum_partial_copy_from_user() into csum_and_copy_from_user()
date:   9 months ago
config: alpha-randconfig-r031-20210211 (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=808b49da54e640cba5c5c92dee658018a529226b
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 808b49da54e640cba5c5c92dee658018a529226b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user' [-Werror=missing-prototypes]
     328 | csum_and_copy_from_user(const void __user *src, void *dst, int len,
         | ^~~~~~~~~~~~~~~~~~~~~~~
   arch/alpha/lib/csum_partial_copy.c:375:1: error: no previous prototype for 'csum_partial_copy_nocheck' [-Werror=missing-prototypes]
     375 | csum_partial_copy_nocheck(const void *src, void *dst, int len, __wsum sum)
         | ^~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +/csum_and_copy_from_user +328 arch/alpha/lib/csum_partial_copy.c

   326	
   327	__wsum
 > 328	csum_and_copy_from_user(const void __user *src, void *dst, int len,
   329				       __wsum sum, int *errp)
   330	{
   331		unsigned long checksum = (__force u32) sum;
   332		unsigned long soff = 7 & (unsigned long) src;
   333		unsigned long doff = 7 & (unsigned long) dst;
   334	
   335		if (len) {
   336			if (!access_ok(src, len)) {
   337				if (errp) *errp = -EFAULT;
   338				memset(dst, 0, len);
   339				return sum;
   340			}
   341			if (!doff) {
   342				if (!soff)
   343					checksum = csum_partial_cfu_aligned(
   344						(const unsigned long __user *) src,
   345						(unsigned long *) dst,
   346						len-8, checksum, errp);
   347				else
   348					checksum = csum_partial_cfu_dest_aligned(
   349						(const unsigned long __user *) src,
   350						(unsigned long *) dst,
   351						soff, len-8, checksum, errp);
   352			} else {
   353				unsigned long partial_dest;
   354				ldq_u(partial_dest, dst);
   355				if (!soff)
   356					checksum = csum_partial_cfu_src_aligned(
   357						(const unsigned long __user *) src,
   358						(unsigned long *) dst,
   359						doff, len-8, checksum,
   360						partial_dest, errp);
   361				else
   362					checksum = csum_partial_cfu_unaligned(
   363						(const unsigned long __user *) src,
   364						(unsigned long *) dst,
   365						soff, doff, len-8, checksum,
   366						partial_dest, errp);
   367			}
   368			checksum = from64to16 (checksum);
   369		}
   370		return (__force __wsum)checksum;
   371	}
   372	EXPORT_SYMBOL(csum_and_copy_from_user);
   373	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32552 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user'
  2021-02-11 23:26 kernel test robot
@ 2021-02-12  2:52 ` Randy Dunlap
  2021-02-14 22:59   ` Al Viro
  0 siblings, 1 reply; 7+ messages in thread
From: Randy Dunlap @ 2021-02-12  2:52 UTC (permalink / raw)
  To: kernel test robot, Al Viro; +Cc: kbuild-all, linux-kernel

On 2/11/21 3:26 PM, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   291009f656e8eaebbdfd3a8d99f6b190a9ce9deb
> commit: 808b49da54e640cba5c5c92dee658018a529226b alpha: turn csum_partial_copy_from_user() into csum_and_copy_from_user()
> date:   9 months ago
> config: alpha-defconfig (attached as .config)
> compiler: alpha-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=808b49da54e640cba5c5c92dee658018a529226b
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout 808b49da54e640cba5c5c92dee658018a529226b
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>>> arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user' [-Werror=missing-prototypes]
>      328 | csum_and_copy_from_user(const void __user *src, void *dst, int len,
>          | ^~~~~~~~~~~~~~~~~~~~~~~
>    arch/alpha/lib/csum_partial_copy.c:375:1: error: no previous prototype for 'csum_partial_copy_nocheck' [-Werror=missing-prototypes]
>      375 | csum_partial_copy_nocheck(const void *src, void *dst, int len, __wsum sum)
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~
>    cc1: all warnings being treated as errors

I can't reproduce this (wrong version of gcc) but it looks like adding
#include <asm/checksum.h>
to arch/alpha/lib/csum_partial_copy.c should fix the warnings.

-- 
~Randy


^ permalink raw reply	[flat|nested] 7+ messages in thread

* arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user'
@ 2021-02-11 23:26 kernel test robot
  2021-02-12  2:52 ` Randy Dunlap
  0 siblings, 1 reply; 7+ messages in thread
From: kernel test robot @ 2021-02-11 23:26 UTC (permalink / raw)
  To: Al Viro; +Cc: kbuild-all, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 3466 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   291009f656e8eaebbdfd3a8d99f6b190a9ce9deb
commit: 808b49da54e640cba5c5c92dee658018a529226b alpha: turn csum_partial_copy_from_user() into csum_and_copy_from_user()
date:   9 months ago
config: alpha-defconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=808b49da54e640cba5c5c92dee658018a529226b
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 808b49da54e640cba5c5c92dee658018a529226b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user' [-Werror=missing-prototypes]
     328 | csum_and_copy_from_user(const void __user *src, void *dst, int len,
         | ^~~~~~~~~~~~~~~~~~~~~~~
   arch/alpha/lib/csum_partial_copy.c:375:1: error: no previous prototype for 'csum_partial_copy_nocheck' [-Werror=missing-prototypes]
     375 | csum_partial_copy_nocheck(const void *src, void *dst, int len, __wsum sum)
         | ^~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +/csum_and_copy_from_user +328 arch/alpha/lib/csum_partial_copy.c

   326	
   327	__wsum
 > 328	csum_and_copy_from_user(const void __user *src, void *dst, int len,
   329				       __wsum sum, int *errp)
   330	{
   331		unsigned long checksum = (__force u32) sum;
   332		unsigned long soff = 7 & (unsigned long) src;
   333		unsigned long doff = 7 & (unsigned long) dst;
   334	
   335		if (len) {
   336			if (!access_ok(src, len)) {
   337				if (errp) *errp = -EFAULT;
   338				memset(dst, 0, len);
   339				return sum;
   340			}
   341			if (!doff) {
   342				if (!soff)
   343					checksum = csum_partial_cfu_aligned(
   344						(const unsigned long __user *) src,
   345						(unsigned long *) dst,
   346						len-8, checksum, errp);
   347				else
   348					checksum = csum_partial_cfu_dest_aligned(
   349						(const unsigned long __user *) src,
   350						(unsigned long *) dst,
   351						soff, len-8, checksum, errp);
   352			} else {
   353				unsigned long partial_dest;
   354				ldq_u(partial_dest, dst);
   355				if (!soff)
   356					checksum = csum_partial_cfu_src_aligned(
   357						(const unsigned long __user *) src,
   358						(unsigned long *) dst,
   359						doff, len-8, checksum,
   360						partial_dest, errp);
   361				else
   362					checksum = csum_partial_cfu_unaligned(
   363						(const unsigned long __user *) src,
   364						(unsigned long *) dst,
   365						soff, doff, len-8, checksum,
   366						partial_dest, errp);
   367			}
   368			checksum = from64to16 (checksum);
   369		}
   370		return (__force __wsum)checksum;
   371	}
   372	EXPORT_SYMBOL(csum_and_copy_from_user);
   373	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 13763 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-05-06 14:27 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-19 19:10 arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user' kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2021-05-06 14:26 kernel test robot
2021-03-19 11:52 kernel test robot
2021-02-12  8:33 kernel test robot
2021-02-11 23:26 kernel test robot
2021-02-12  2:52 ` Randy Dunlap
2021-02-14 22:59   ` Al Viro

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).