From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 474BBC433E0 for ; Mon, 22 Mar 2021 17:10:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17945619A5 for ; Mon, 22 Mar 2021 17:10:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230018AbhCVRJ4 (ORCPT ); Mon, 22 Mar 2021 13:09:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27757 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229986AbhCVRJx (ORCPT ); Mon, 22 Mar 2021 13:09:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616432993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z/si1mnnKmFIE1GT/iAXFZg1UC144TFTltD99tuo99U=; b=UNe6+joZWaV8hWR0YjYwENyT7IPEg6pJQMgY4WT1sWi6PnnG1TOANYC6v8H9ohFIiaoyCj 0AbasDQTEFQe4sQXCTOmvKX/mRzTHxDEVHjmhuDOx+wyqZZakcNNVBWBxBOCwQDRJ02wA/ Z4pR2hsRKmRZ5po6QezkOWuDQxsSzow= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-259-TU20hLqJNaKe6kdKK3iryg-1; Mon, 22 Mar 2021 13:09:51 -0400 X-MC-Unique: TU20hLqJNaKe6kdKK3iryg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 436331084D70; Mon, 22 Mar 2021 17:09:49 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.40.194.114]) by smtp.corp.redhat.com (Postfix) with SMTP id 01EE760D43; Mon, 22 Mar 2021 17:09:46 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 22 Mar 2021 18:09:48 +0100 (CET) Date: Mon, 22 Mar 2021 18:09:45 +0100 From: Oleg Nesterov To: qianli zhao Cc: "Eric W. Biederman" , christian@brauner.io, axboe@kernel.dk, Thomas Gleixner , Peter Collingbourne , linux-kernel@vger.kernel.org, Qianli Zhao Subject: Re: [PATCH V3] exit: trigger panic when global init has exited Message-ID: <20210322170945.GF20390@redhat.com> References: <1615985460-112867-1-git-send-email-zhaoqianligood@gmail.com> <20210317143805.GA5610@redhat.com> <20210318180450.GA9977@redhat.com> <20210322170733.GE20390@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210322170733.GE20390@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/22, Oleg Nesterov wrote: > > On 03/22, qianli zhao wrote: > > > > Moving the decrement position should only affect between new and old > > code position of movement of the decrement of > > signal->live. > > Why do you think so? It can affect _any_ code which runs under > "if (group_dead)". Again, I don't see anything wrong, but I didn't even > try to audit these code paths. forgot to mention... and any code outside of do_exit() which checks signal->live. Oleg.