From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6C37C433E0 for ; Mon, 22 Mar 2021 17:59:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DA1661974 for ; Mon, 22 Mar 2021 17:59:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231289AbhCVR6y (ORCPT ); Mon, 22 Mar 2021 13:58:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42366 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231249AbhCVR6g (ORCPT ); Mon, 22 Mar 2021 13:58:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616435914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DxP0GIfbRmVMNqia/UkYOYfywTCnzVTGK716pBxi6aM=; b=MC98qlx6SLXJnPotvdFsscJRN7gDq5rDr/0xNUkojbK2oXRrCaCQDaiApqmdy/WT17Kfx2 fdsV2KS/0nMdCEYN/v4qI8M64HJDM5YBS0cYsXYyT0zPhxxuM1btJ3N6RSRkt0pTJTfRDK 34fB1V/GsN4agxFNwdmyxJm68+wuK4Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-293-8yY8mH_kM86_phDvTxLw9w-1; Mon, 22 Mar 2021 13:58:32 -0400 X-MC-Unique: 8yY8mH_kM86_phDvTxLw9w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F00C38030D6; Mon, 22 Mar 2021 17:58:30 +0000 (UTC) Received: from madcap2.tricolour.ca (unknown [10.10.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 32BC11002388; Mon, 22 Mar 2021 17:58:24 +0000 (UTC) Date: Mon, 22 Mar 2021 13:58:21 -0400 From: Richard Guy Briggs To: Arnd Bergmann Cc: Paul Moore , Eric Paris , Jules Irenge , linux-audit@redhat.com, Linux Kernel Mailing List Subject: Re: [PATCH] audit: avoid -Wempty-body warning Message-ID: <20210322175821.GO3141668@madcap2.tricolour.ca> References: <20210322114536.3517661-1-arnd@kernel.org> <20210322143344.GN3141668@madcap2.tricolour.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-03-22 17:28, Arnd Bergmann wrote: > On Mon, Mar 22, 2021 at 3:33 PM Richard Guy Briggs wrote: > > > Change the macros to use the usual "do { } while (0)" instead, and change a > > > few more that were (void)0, for consistency. > > > > So what about audit_put_watch() and audit_get_watch() which are set to > > {}? (And all of include/linux/audit.h that uses the latter...) Does > > this only matter if they are the only action called in an if or loop? > > I missed those, thanks for pointing it out. I sent a v2 patch now. Ok, cool, that looks more consistent. Can you answer my question about include/linux/audit.h and exactly what conditions require "do { } while (0)" over "{ }"? > Arnd - RGB -- Richard Guy Briggs Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635