From: lihaiwei.kernel@gmail.com
To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com,
wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org,
Haiwei Li <lihaiwei@tencent.com>
Subject: [PATCH] KVM: VMX: Check the corresponding bits according to the intel sdm
Date: Tue, 23 Mar 2021 10:37:26 +0800 [thread overview]
Message-ID: <20210323023726.28343-1-lihaiwei.kernel@gmail.com> (raw)
From: Haiwei Li <lihaiwei@tencent.com>
According to IA-32 SDM Vol.3D "A.1 BASIC VMX INFORMATION", two inspections
are missing.
* Bit 31 is always 0. Earlier versions of this manual specified that the
VMCS revision identifier was a 32-bit field in bits 31:0 of this MSR. For
all processors produced prior to this change, bit 31 of this MSR was read
as 0.
* The values of bits 47:45 and bits 63:57 are reserved and are read as 0.
Signed-off-by: Haiwei Li <lihaiwei@tencent.com>
---
arch/x86/kvm/vmx/vmx.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index 32cf828..0d6d13c 100644
--- a/arch/x86/kvm/vmx/vmx.c
+++ b/arch/x86/kvm/vmx/vmx.c
@@ -2577,6 +2577,20 @@ static __init int setup_vmcs_config(struct vmcs_config *vmcs_conf,
rdmsr(MSR_IA32_VMX_BASIC, vmx_msr_low, vmx_msr_high);
+ /*
+ * IA-32 SDM Vol 3D: Bit 31 is always 0.
+ * For all earlier processors, bit 31 of this MSR was read as 0.
+ */
+ if (vmx_msr_low & (1u<<31))
+ return -EIO;
+
+ /*
+ * IA-32 SDM Vol 3D: bits 47:45 and bits 63:57 are reserved and are read
+ * as 0.
+ */
+ if (vmx_msr_high & 0xfe00e000)
+ return -EIO;
+
/* IA-32 SDM Vol 3B: VMCS size is never greater than 4kB. */
if ((vmx_msr_high & 0x1fff) > PAGE_SIZE)
return -EIO;
--
1.8.3.1
next reply other threads:[~2021-03-23 2:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 2:37 lihaiwei.kernel [this message]
2021-03-23 3:16 ` [PATCH] KVM: VMX: Check the corresponding bits according to the intel sdm Jim Mattson
2021-03-23 4:42 ` Haiwei Li
2021-03-25 13:22 ` Haiwei Li
2021-03-25 15:49 ` Sean Christopherson
2021-03-26 0:39 ` Haiwei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210323023726.28343-1-lihaiwei.kernel@gmail.com \
--to=lihaiwei.kernel@gmail.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=lihaiwei@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).