From: "Paul E. McKenney" <paulmck@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: Fix various typos in comments
Date: Mon, 22 Mar 2021 22:32:31 -0700 [thread overview]
Message-ID: <20210323053231.GT2696@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <70fcf956-5242-db43-b039-eb82f722eb36@infradead.org>
On Mon, Mar 22, 2021 at 07:55:05PM -0700, Randy Dunlap wrote:
> On 3/22/21 4:02 PM, Ingo Molnar wrote:
> >
> > Hi Paul,
> >
> > Was working on automation to make it a bit more straightforward to fix
> > typos within comments (which we tend to reintroduce during
> > development), and here are the ones it found in the RCU code.
> >
> > Thanks,
> >
> > Ingo
> >
> > =========>
> > From: Ingo Molnar <mingo@kernel.org>
> > Date: Mon, 22 Mar 2021 23:57:26 +0100
> > Subject: [PATCH] rcu: Fix various typos in comments
> >
> > Fix ~12 single-word typos in RCU code comments.
> >
> > Signed-off-by: Ingo Molnar <mingo@kernel.org>
> > Cc: Paul E. McKenney <paulmck@kernel.org>
> > Cc: linux-kernel@vger.kernel.org
> > ---
> > kernel/rcu/srcutree.c | 4 ++--
> > kernel/rcu/sync.c | 2 +-
> > kernel/rcu/tasks.h | 8 ++++----
> > kernel/rcu/tree.c | 4 ++--
> > kernel/rcu/tree.h | 2 +-
> > kernel/rcu/tree_plugin.h | 2 +-
> > tools/testing/selftests/rcutorture/formal/srcu-cbmc/src/locks.h | 2 +-
> > 7 files changed, 12 insertions(+), 12 deletions(-)
>
> > diff --git a/kernel/rcu/sync.c b/kernel/rcu/sync.c
> > index d4558ab7a07d..3eeb871cf0de 100644
> > --- a/kernel/rcu/sync.c
> > +++ b/kernel/rcu/sync.c
> > @@ -94,7 +94,7 @@ static void rcu_sync_func(struct rcu_head *rhp)
> > rcu_sync_call(rsp);
> > } else {
> > /*
> > - * We're at least a GP after the last rcu_sync_exit(); eveybody
> > + * We're at least a GP after the last rcu_sync_exit(); everybody
> > * will now have observed the write side critical section.
> > * Let 'em rip!.
>
> Drop the '.'.
>
> > */
> Otherwise LGTM. Thanks.
>
> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Applied, dropping the "." and adding the Reviewed-by.
Thank you both!
Thanx, Paul
next prev parent reply other threads:[~2021-03-23 5:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 23:02 [PATCH] rcu: Fix various typos in comments Ingo Molnar
2021-03-23 2:55 ` Randy Dunlap
2021-03-23 5:32 ` Paul E. McKenney [this message]
2021-03-23 2:56 ` Bhaskar Chowdhury
2021-03-23 5:36 ` Paul E. McKenney
2021-03-23 11:17 ` Ingo Molnar
2021-03-23 16:20 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210323053231.GT2696@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).