From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16C67C433E9 for ; Wed, 24 Mar 2021 02:05:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E600B61A24 for ; Wed, 24 Mar 2021 02:05:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234801AbhCXCFQ (ORCPT ); Tue, 23 Mar 2021 22:05:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234735AbhCXCFB (ORCPT ); Tue, 23 Mar 2021 22:05:01 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14DF9C061765 for ; Tue, 23 Mar 2021 19:04:53 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id m7so13598811pgj.8 for ; Tue, 23 Mar 2021 19:04:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=br6Q9nB7EzUYGhvzSIch8sIAGewUeFhxJoVc038K6FM=; b=gCj9wu0DPQF3nxAjDePTGT6o/I3+3MFaoBuS0S8SRkHISCvcx2hCBGamPTxp7WSFkC yb2AgkaKXYAtLhlAABCIWTa2wJ7QKwWFeS0WDtlpZsM/3y3vCZpvdNjeczYqN1c2rDxR NhhB9N90GDPUbtPYn6wJKwLWxWw3dM6N5grf8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=br6Q9nB7EzUYGhvzSIch8sIAGewUeFhxJoVc038K6FM=; b=XATRqm/qHFTpeAkv9t8XVu7AGGW/z7LfTAi4zfw8SDSfi08gfZuiPoOT4z0VrvQ5pn txo9aQmsT7jnUPujwlThpUjdQzwKWDwF02niA5R5AhkcpwUWzVeQFIvJN2m8/eCSueYL shLDZrV8+5CmdlqDpFGECLf5bktja4rM4N2vQdbTYE3seFwhccLYkouOlfGF9Lvq7uxI 5zf3nv3AuhKt8d+2FgtXB2ZLCgxP7uQySTxUD1Z5W4oxq8vMZJtxGrZpZn839vGs7Y2S UlAKINiwsajb+deRE34N2M46u7UUGONWGnXfzITQh8NHYhh2N0raz4yAgusmzyHnJR9L wuBA== X-Gm-Message-State: AOAM531c53PRQSAiG5xcvPtpjTDnaKRqJKfSGvGgYbPY0Mjz16w8Dfmy T7WpRv6T5Z8QF7zKQY+/8dPksInmOXWx1Q== X-Google-Smtp-Source: ABdhPJya/tUfqxOxrzzqmFmGwgYqGsx9kpRcIhIF5cAHE/qmNC2FD8WYBf/aeveCHq1MxO1+5L+awg== X-Received: by 2002:aa7:8ec4:0:b029:1ee:f581:ec12 with SMTP id b4-20020aa78ec40000b02901eef581ec12mr966245pfr.0.1616551492667; Tue, 23 Mar 2021 19:04:52 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:84ac:62f7:16a8:ccc7]) by smtp.gmail.com with ESMTPSA id b3sm389441pjg.41.2021.03.23.19.04.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 19:04:52 -0700 (PDT) From: Stephen Boyd To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Jiri Olsa , Alexei Starovoitov , Jessica Yu , Evan Green , Hsin-Yi Wang , Petr Mladek , Steven Rostedt , Andy Shevchenko , Matthew Wilcox Subject: [PATCH v2 05/12] arm64: stacktrace: Use %pSb for backtrace printing Date: Tue, 23 Mar 2021 19:04:36 -0700 Message-Id: <20210324020443.1815557-6-swboyd@chromium.org> X-Mailer: git-send-email 2.31.0.291.g576ba9dcdaf-goog In-Reply-To: <20210324020443.1815557-1-swboyd@chromium.org> References: <20210324020443.1815557-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Let's use the new printk format to print the stacktrace entry when printing a backtrace to the kernel logs. This will include any module's build ID[1] in it so that offline/crash debugging can easily locate the debuginfo for a module via something like debuginfod[2]. Cc: Catalin Marinas Cc: Will Deacon Cc: Cc: Jiri Olsa Cc: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Cc: Petr Mladek Cc: Steven Rostedt Cc: Andy Shevchenko Cc: Matthew Wilcox Link: https://fedoraproject.org/wiki/Releases/FeatureBuildId [1] Link: https://sourceware.org/elfutils/Debuginfod.html [2] Signed-off-by: Stephen Boyd --- arch/arm64/kernel/stacktrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index ad20981dfda4..9d38da01ff98 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -129,7 +129,7 @@ NOKPROBE_SYMBOL(walk_stackframe); static void dump_backtrace_entry(unsigned long where, const char *loglvl) { - printk("%s %pS\n", loglvl, (void *)where); + printk("%s %pSb\n", loglvl, (void *)where); } void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk, -- https://chromeos.dev