From: Lee Jones <lee.jones@linaro.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: j.neuschaefer@gmx.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] mfd: ntxec: Support for EC in Tolino Shine 2 HD
Date: Wed, 24 Mar 2021 10:25:49 +0000 [thread overview]
Message-ID: <20210324102549.GG2916463@dell> (raw)
In-Reply-To: <20210315191832.16842-1-andreas@kemnade.info>
On Mon, 15 Mar 2021, Andreas Kemnade wrote:
> Add the version of the EC in the Tolino Shine 2 HD
> to the supported versions. It seems not to have an RTC
> and does not ack data written to it.
> The vendor kernel happily ignores write errors, using
> I2C via userspace i2c-set also shows the error.
> So add a quirk to ignore that error.
>
> PWM can be successfully configured despite of that error.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
> Changes in v4:
> - rename subdevices back to v2 (suggested by Jonathan)
> - initialize subdevs in switch
>
> Changes in v3:
> - remove have_rtc variable
> - rename subdevices again
>
> Changes in v2:
> - more comments about stacking regmap construction
> - fix accidential line removal
> - better naming for subdevices
>
> drivers/mfd/ntxec.c | 56 ++++++++++++++++++++++++++++++++++++---
> include/linux/mfd/ntxec.h | 1 +
> 2 files changed, 54 insertions(+), 3 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-03-24 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 19:18 [PATCH v4] mfd: ntxec: Support for EC in Tolino Shine 2 HD Andreas Kemnade
2021-03-24 10:25 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324102549.GG2916463@dell \
--to=lee.jones@linaro.org \
--cc=andreas@kemnade.info \
--cc=j.neuschaefer@gmx.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).