From: Oleg Nesterov <oleg@redhat.com>
To: qianli zhao <zhaoqianligood@gmail.com>
Cc: christian@brauner.io, axboe@kernel.dk,
"Eric W. Biederman" <ebiederm@xmission.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Collingbourne <pcc@google.com>,
linux-kernel@vger.kernel.org, Qianli Zhao <zhaoqianli@xiaomi.com>
Subject: Re: [PATCH V3] exit: trigger panic when global init has exited
Date: Wed, 24 Mar 2021 19:12:10 +0100 [thread overview]
Message-ID: <20210324181209.GB13021@redhat.com> (raw)
In-Reply-To: <CAPx_LQH0Qx7R9vNb3FHgO7V8uJ9AAh0j_TZV-VnyBF7Ys_7FTQ@mail.gmail.com>
Hi,
On 03/23, qianli zhao wrote:
>
> Hi,Oleg
>
> > You certainly don't understand me :/
>
> > Please read my email you quoted below. I didn't mean the current logic.
> > I meant the logic after your patch which moves atomic_dec_and_test() and
> > panic() before exit_signals().
>
> Sorry, I think I see what you mean now.
>
> You mean that after apply my patch,SIGNAL_GROUP_EXIT no longer needs
> to be tested or avoid zap_pid_ns_processes()->BUG().
> Yes,your consideration is correct.
OK, great
> But,my patch has another purpose,protect some key variables(such
> as:task->mm,task->nsproxy,etc) to recover init coredump from
> fulldump,if sub-threads finish do_exit(),
Yes I know.
But the purpose of this SIGNAL_GROUP_EXIT check is not clear and not
documented. That is why I said it should be documented at least in the
changelog.
Oleg.
next prev parent reply other threads:[~2021-03-24 18:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 12:51 [PATCH V3] exit: trigger panic when global init has exited Qianli Zhao
2021-03-17 14:38 ` Oleg Nesterov
2021-03-18 2:47 ` qianli zhao
2021-03-18 18:04 ` Oleg Nesterov
2021-03-18 19:08 ` Eric W. Biederman
2021-03-19 6:33 ` qianli zhao
2021-03-19 16:34 ` Oleg Nesterov
2021-03-19 16:26 ` Oleg Nesterov
2021-03-21 16:00 ` qianli zhao
2021-03-22 17:07 ` Oleg Nesterov
2021-03-22 17:09 ` Oleg Nesterov
2021-03-19 5:08 ` qianli zhao
2021-03-19 16:32 ` Oleg Nesterov
2021-03-21 13:04 ` qianli zhao
2021-03-22 16:37 ` Oleg Nesterov
2021-03-23 3:14 ` qianli zhao
2021-03-23 9:00 ` Oleg Nesterov
2021-03-23 11:23 ` qianli zhao
2021-03-24 18:12 ` Oleg Nesterov [this message]
2021-03-25 3:00 ` qianli zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324181209.GB13021@redhat.com \
--to=oleg@redhat.com \
--cc=axboe@kernel.dk \
--cc=christian@brauner.io \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pcc@google.com \
--cc=tglx@linutronix.de \
--cc=zhaoqianli@xiaomi.com \
--cc=zhaoqianligood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).