From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org,
mcoquelin.stm32@gmail.com, weifeng.voon@intel.com,
boon.leong.ong@intel.com, qiangqing.zhang@nxp.com,
vee.khee.wong@intel.com, fugang.duan@nxp.com,
kim.tatt.chuah@intel.com, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, andrew@lunn.ch,
hkallweit1@gmail.com
Subject: Re: [PATCH net-next v3 2/2] net: pcs: configure xpcs 2.5G speed mode
Date: Thu, 25 Mar 2021 08:59:03 +0000 [thread overview]
Message-ID: <20210325085902.GK1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210325083806.19382-3-michael.wei.hong.sit@intel.com>
On Thu, Mar 25, 2021 at 04:38:06PM +0800, Michael Sit Wei Hong wrote:
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index 12a047d47dec..c95dfe4e5310 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -290,6 +290,8 @@ static int phylink_parse_mode(struct phylink *pl, struct fwnode_handle *fwnode)
>
> switch (pl->link_config.interface) {
> case PHY_INTERFACE_MODE_SGMII:
> + phylink_set(pl->supported, 2500baseT_Full);
> + fallthrough;
This is wrong. "SGMII" here means 1G SGMII. See the documentation in
Documentation/networking/phy.rst.
If we want to have this at 2.5G speed, then we need a separate
enumeration for that mode, just like we make a distinction between
1000BASE-X and 2500BASE-X.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2021-03-25 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 8:38 [PATCH net-next v3 0/2] Enable 2.5Gbps speed for stmmac and xPCS Michael Sit Wei Hong
2021-03-25 8:38 ` [PATCH net-next v3 1/2] net: stmmac: enable 2.5Gbps link speed Michael Sit Wei Hong
2021-03-25 8:38 ` [PATCH net-next v3 2/2] net: pcs: configure xpcs 2.5G speed mode Michael Sit Wei Hong
2021-03-25 8:59 ` Russell King - ARM Linux admin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325085902.GK1463@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=fugang.duan@nxp.com \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kim.tatt.chuah@intel.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael.wei.hong.sit@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=qiangqing.zhang@nxp.com \
--cc=vee.khee.wong@intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).