From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E21BC433E3 for ; Thu, 25 Mar 2021 10:28:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E820E61A37 for ; Thu, 25 Mar 2021 10:27:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230053AbhCYK13 (ORCPT ); Thu, 25 Mar 2021 06:27:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:21493 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229989AbhCYK1B (ORCPT ); Thu, 25 Mar 2021 06:27:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616668021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YnnJOjLqRsNOiRCl1VmxWYaDtnFLgBh+G/O9tqpx3N4=; b=eQBdZo0ZAFBCEb79grPnk85P9vptY2tbCFgwjUTqUW7IhML5wO6/qWqZ/cZRv/KeEcshyb XjaEx/+lScB3AwZyapjoQF7KfRc3zut3hc43eAVMmXg/QDHZGkGE2j82E+NmsnQL6fBVNk 73w75ob4bN3PIrUDeIOEjvN3jpH+H/c= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-584-Nyx0Qiv7Mh-zfzVwuPke7Q-1; Thu, 25 Mar 2021 06:26:59 -0400 X-MC-Unique: Nyx0Qiv7Mh-zfzVwuPke7Q-1 Received: by mail-wm1-f69.google.com with SMTP id i14so1494485wmq.7 for ; Thu, 25 Mar 2021 03:26:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YnnJOjLqRsNOiRCl1VmxWYaDtnFLgBh+G/O9tqpx3N4=; b=PXA85nBkWl/WV1w+48jBthFRNz6S6pb3pEW2hiblgGzCfGLxUutLNyjOadWythDeor 3Vkx4Vwi5MiFelenjwTdNKpWd19gotitvvuVb4Aem5f0MhAdJBdLLtYDCuSk18/vgMS+ 6YOGB6zvjrlyXKqyotxboYO4eeoJG+zMNt7/PtNqORrhWB1rtmgjoCZNzLqwK3Jumkiz 0W9dubtUjjD+muc4aDqHiH1wOFEWw11IDaRHbBxs4jLfYRwgmwgG2xjEUpy6qA59sfPK FfXYKuwcF27XVhbrUW3O05W53+/9jh4xXLxCBZcOEn8w8LcuFnaew4uALdxbsTQ/PTjs j91w== X-Gm-Message-State: AOAM532mv7WiS/dIMUZNgaVuADZ3OqWQxAyEDtbCaQiay6m5alLxxbHH zXWRlA2waVIVhipv0PNBIChFUJCwoPzfQqKtD4DRHY8kROPbsmoRA0EXAa2fR82dlzuZWASAGI3 kF6DZQzGbhaXRK/U7Ff8OxeuK X-Received: by 2002:adf:fd48:: with SMTP id h8mr8238604wrs.229.1616668018214; Thu, 25 Mar 2021 03:26:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBTujIWNkDzf/wNwRNzZd57i5I9jgY+9t+YqLrMxkr/bkSu6aLA/urK8lINmqRAJa9Wu/cyw== X-Received: by 2002:adf:fd48:: with SMTP id h8mr8238578wrs.229.1616668018030; Thu, 25 Mar 2021 03:26:58 -0700 (PDT) Received: from steredhat (host-79-34-249-199.business.telecomitalia.it. [79.34.249.199]) by smtp.gmail.com with ESMTPSA id p17sm5370291wmq.47.2021.03.25.03.26.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 03:26:57 -0700 (PDT) Date: Thu, 25 Mar 2021 11:26:55 +0100 From: Stefano Garzarella To: Arseny Krasnov Cc: Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Jakub Kicinski , Jorgen Hansen , Andra Paraschiv , Norbert Slusarek , Colin Ian King , Alexander Popov , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stsp2@yandex.ru, oxffffaa@gmail.com Subject: Re: [RFC PATCH v7 15/22] virtio/vsock: SEQPACKET support feature bit Message-ID: <20210325102655.ujyfpapvwnubcggn@steredhat> References: <20210323130716.2459195-1-arseny.krasnov@kaspersky.com> <20210323131352.2461534-1-arseny.krasnov@kaspersky.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210323131352.2461534-1-arseny.krasnov@kaspersky.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 23, 2021 at 04:13:49PM +0300, Arseny Krasnov wrote: >This adds new virtio vsock specific feature bit which means >SOCK_SEQPACKET support. Guest negotiates this bit with vhost, >thus checking that vhost side supports SEQPACKET. > >Signed-off-by: Arseny Krasnov >--- > include/uapi/linux/virtio_vsock.h | 3 +++ > 1 file changed, 3 insertions(+) Since you have this patch, I think you can generalize the title, update the description, and merge here the changes I mentioned in patch 11/22 about changes of include/uapi/linux/virtio_vsock.h. So you can have a single patch with the new virtio-spec defines and structs related to SEQPACKET, of course then we move it before patch 11. What do you think? Stefano > >diff --git a/include/uapi/linux/virtio_vsock.h b/include/uapi/linux/virtio_vsock.h >index 692f8078cced..619aaebb355a 100644 >--- a/include/uapi/linux/virtio_vsock.h >+++ b/include/uapi/linux/virtio_vsock.h >@@ -38,6 +38,9 @@ > #include > #include > >+/* The feature bitmap for virtio vsock */ >+#define VIRTIO_VSOCK_F_SEQPACKET 0 /* SOCK_SEQPACKET supported */ >+ > struct virtio_vsock_config { > __le64 guest_cid; > } __attribute__((packed)); >-- >2.25.1 >