linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Liu Xiang <liuxiang1999@gmail.com>
Cc: Liu Xiang <liu.xiang@zlingsmart.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, liuxiang_1999@126.com
Subject: Re: [PATCH] ARM: fix smp_processor_id() in preemptible warning in harden_branch_predictor()
Date: Thu, 25 Mar 2021 14:20:11 +0000	[thread overview]
Message-ID: <20210325142011.GN1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAPPcxxSzNvGu3y+3Fpc5FtV-6mOBPWMihmGhHnbq_qAHe3oYTA@mail.gmail.com>

On Thu, Mar 25, 2021 at 09:32:35PM +0800, Liu Xiang wrote:
> Russell King - ARM Linux admin <linux@armlinux.org.uk> 于2021年3月25日周四 下午6:06写道：
> >
> > On Thu, Mar 25, 2021 at 05:50:49PM +0800, Liu Xiang wrote:
> > > When CONFIG_HARDEN_BRANCH_PREDICTOR is selected and user aborts occur,
> > > there is a warning:
> > >
> > > BUG: using smp_processor_id() in preemptible [00000000] code: errnotest/577
> > > caller is __do_user_fault.constprop.4+0x24/0x88
> > > CPU: 1 PID: 577 Comm: errnotest Not tainted 4.14.188-rt87-fmsh-00004-g58055877a #1
> > > Hardware name: FMSH PSOC Platform
> > > [<8010d6d4>] (unwind_backtrace) from [<8010a228>] (show_stack+0x10/0x14)
> > > [<8010a228>] (show_stack) from [<80698f44>] (dump_stack+0x7c/0x98)
> > > [<80698f44>] (dump_stack) from [<803d17d0>] (check_preemption_disabled+0xc4/0xfc)
> > > [<803d17d0>] (check_preemption_disabled) from [<80110eb8>] (__do_user_fault.constprop.4+0x24/0x88)
> > > [<80110eb8>] (__do_user_fault.constprop.4) from [<801112e4>] (do_page_fault+0x2dc/0x310)
> > > [<801112e4>] (do_page_fault) from [<801012a8>] (do_DataAbort+0x38/0xb8)
> > > [<801012a8>] (do_DataAbort) from [<8010b03c>] (__dabt_usr+0x3c/0x40)
> > > Exception stack(0xb21d1fb0 to 0xb21d1ff8)
> > > 1fa0:                                     fffffff4 00000000 00000054 fffffff4
> > > 1fc0: 00000000 00000000 7ed81cc8 7ed81ca0 0007a440 00000000 00000000 00000000
> > > 1fe0: 00000000 7ed81ca0 00010493 0001f330 20030010 ffffffff
> >
> > This is not the right fix - preemption is supposed to be disabled before
> > this function is called. I'm not sure at the present time what the right
> > fix is supposed to be because I've forgotten most of the background
> > behind why this was placed where it is.
> >
> > --
> > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
> 
> I have tested with the current mainline kernel, the warning still exists.

Yes, it still exists, because it's never been fixed, but the way you are
fixing it is not correct. We do not paper over warnings with incorrect
fixes.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

      reply	other threads:[~2021-03-25 14:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-25  9:50 [PATCH] ARM: fix smp_processor_id() in preemptible warning in harden_branch_predictor() Liu Xiang
2021-03-25 10:06 ` Russell King - ARM Linux admin
2021-03-25 13:32   ` Liu Xiang
2021-03-25 14:20     ` Russell King - ARM Linux admin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210325142011.GN1463@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liu.xiang@zlingsmart.com \
    --cc=liuxiang1999@gmail.com \
    --cc=liuxiang_1999@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).