From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C10FC433DB for ; Thu, 25 Mar 2021 16:33:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D72C61993 for ; Thu, 25 Mar 2021 16:33:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229854AbhCYQcm (ORCPT ); Thu, 25 Mar 2021 12:32:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbhCYQcO (ORCPT ); Thu, 25 Mar 2021 12:32:14 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34D10C06174A for ; Thu, 25 Mar 2021 09:32:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oOdLjHuIxXVhFe5pzP0CyL1J+H1PHxVj/9t6qQoloCs=; b=LJ3w7uwjOEReT7g5/1kN2W63Th nknfOx1CZbDLdSf3Bm8PXbCWukIPpcnQwRkAU77asfGQkWP2U+5hX4UR7sf+fCnH9XSbn814bWnB2 YMPr/v6vd14q7yiF4aQsFiQUknpn7iAluTRFyOodzJREENYVeWxYxKmkmCXNd5VtGw+QtW4MDQgl1 Wi3HvRe9o+KbDyQIHoYNZuOnrmzTlUjFIvuiZA4pK2W1RoEfzsjXG4yP7iDSg7CP3OqfY+H/sMKqB Gmg5TRst6E/TC0Wfn6Z11YEAO8UCuFu12mT3loyW0RR6pvslyzwGqriTMDpvFkyaguoIw6yb+5jJi sh8KMeug==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lPStI-00DJHp-4n; Thu, 25 Mar 2021 16:31:39 +0000 Date: Thu, 25 Mar 2021 16:31:24 +0000 From: Matthew Wilcox To: David Laight Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Uladzislau Rezki , Nicholas Piggin Subject: Re: [PATCH v2 0/4] vmalloc: Improve vmalloc(4MB) performance Message-ID: <20210325163124.GY1719932@casper.infradead.org> References: <20210324150518.2734402-1-willy@infradead.org> <38da93959bc948c992fc7fc1efd4d25c@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <38da93959bc948c992fc7fc1efd4d25c@AcuMS.aculab.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 25, 2021 at 03:59:56PM +0000, David Laight wrote: > Even then it is probably better to use a typed pointer thank you for expressing your opinion