Hi Heikki, I love your patch! Yet something to improve: [auto build test ERROR on peter.chen-usb/for-usb-next] [also build test ERROR on linus/master v5.12-rc4 next-20210325] [cannot apply to usb/usb-testing chrome-platform-linux/for-next balbi-usb/testing/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Heikki-Krogerus/usb-Linking-ports-to-their-Type-C-connectors/20210325-203239 base: https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git for-usb-next config: i386-randconfig-a015-20210325 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/3f5d8681c4754fba373563812803b8d5eb11639a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Heikki-Krogerus/usb-Linking-ports-to-their-Type-C-connectors/20210325-203239 git checkout 3f5d8681c4754fba373563812803b8d5eb11639a # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): ld: drivers/usb/typec/port-mapper.o: in function `typec_link_ports': >> drivers/usb/typec/port-mapper.c:260: undefined reference to `usb_for_each_port' vim +260 drivers/usb/typec/port-mapper.c 251 252 int typec_link_ports(struct typec_port *con) 253 { 254 int ret; 255 256 con->pld = get_pld(&con->dev); 257 if (!con->pld) 258 return 0; 259 > 260 ret = usb_for_each_port(&con->dev, connector_match); 261 if (ret) 262 typec_unlink_ports(con); 263 264 return ret; 265 } 266 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org