From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46895C433E6 for ; Fri, 26 Mar 2021 09:12:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B7F761A3F for ; Fri, 26 Mar 2021 09:12:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230053AbhCZJMd (ORCPT ); Fri, 26 Mar 2021 05:12:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230247AbhCZJMC (ORCPT ); Fri, 26 Mar 2021 05:12:02 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC7F4C0613AA for ; Fri, 26 Mar 2021 02:12:01 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id h13so5473919eds.5 for ; Fri, 26 Mar 2021 02:12:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0HmJyYvfh3odbCbwdOHWuZiUzII2bd3LZhTWqsOobYI=; b=n4W+q8U1a7bC6pi556mT5k5hMy1KI00tVUZVKF+u9/+mx1LHcdDx8IttHymfZup98e jYkvCIvyQpooj+2wez8syLuZpdWBP3+LNkRHF6eG1SyEgIr4w/B1ziqLyZJmCBNU4hbX VpqbuZUezoKN6PCnsp066VPn1MHAa2amQDvgfxZ0pIb6rhIHfeC7BmI7BCA2b2efb9TS PxqPYIvF/k/sV9ADUQc3RhP1R0TgtxAQWG/tjsEPRGT7MamZxnCJzAGnch/twVV2KuB1 KHyqJnCEow84Rqt7N+h4P8hJFRqn8O1uh7Tpk/jRcjZANBVOQ+krEVBPYORYEcQxO+Ve KTpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0HmJyYvfh3odbCbwdOHWuZiUzII2bd3LZhTWqsOobYI=; b=a3x17ZizkoFpJ2LJTjnjgv0cFVhN6u2HoA4wluzzmCLUVNXWArr0q9Yw+Fi+4yk+MQ 6L02ag2V3AxLRS8EamU7FQ6yNhv78dqepOEAbSNCHYh1x2uF/12uW1zFqDMc88k6Au3+ /OvUM1+pm+T+9eMuFW49zyvY9uTSWowfTQY+V7EPKv9y6f/vAJIAl4jZVcB/48+PJp64 hV/5DelfOiXd0reRONCZha6bc7QnDujizo9ymWIi+u2S8IEiwx3vYudqocvOg31OMZ21 8z/Q1fFKaENNX1N9aD914gfHebiuDnWKtW/9ii8ennjliIg5C6HpPpQ8mzErnqzgVIb6 l1Ng== X-Gm-Message-State: AOAM532vcGr6UfSvAGYKtiZwvqrb7hIx1C9+MUOyQz7JBE7zxtA0gHM9 1u7JlrQegn6I/IL6r3ocVc+C2A== X-Google-Smtp-Source: ABdhPJwcTGxKuSBwMe2dMJDiuvrGr8lNWPG+oL26fueAytWs2j7U54il3jlM5OiuJ+e4Af833Pa2LQ== X-Received: by 2002:a50:fd8b:: with SMTP id o11mr13665751edt.346.1616749920526; Fri, 26 Mar 2021 02:12:00 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id r13sm3895645edy.3.2021.03.26.02.11.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 02:12:00 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Bob Peterson , Andreas Gruenbacher , cluster-devel@redhat.com Subject: [PATCH 06/18] fs: gfs2: lops: Help out worthy kernel-doc headers and demote others Date: Fri, 26 Mar 2021 09:11:39 +0000 Message-Id: <20210326091151.311647-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326091151.311647-1-lee.jones@linaro.org> References: <20210326091151.311647-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): fs/gfs2/lops.c:106: warning: Function parameter or member 'tr' not described in 'gfs2_unpin' fs/gfs2/lops.c:106: warning: Excess function parameter 'flags' description in 'gfs2_unpin' fs/gfs2/lops.c:300: warning: Function parameter or member 'biop' not described in 'gfs2_log_get_bio' fs/gfs2/lops.c:300: warning: Excess function parameter 'bio' description in 'gfs2_log_get_bio' fs/gfs2/lops.c:333: warning: Function parameter or member 'jd' not described in 'gfs2_log_write' fs/gfs2/lops.c:428: warning: Function parameter or member 'head' not described in 'gfs2_jhead_pg_srch' fs/gfs2/lops.c:471: warning: Function parameter or member 'head' not described in 'gfs2_jhead_process_page' fs/gfs2/lops.c:513: warning: Function parameter or member 'keep_cache' not described in 'gfs2_find_jhead' fs/gfs2/lops.c:983: warning: Function parameter or member 'sdp' not described in 'databuf_lo_before_commit' fs/gfs2/lops.c:983: warning: Function parameter or member 'tr' not described in 'databuf_lo_before_commit' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/lops.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c index a82f4747aa8d5..390ac939aa757 100644 --- a/fs/gfs2/lops.c +++ b/fs/gfs2/lops.c @@ -92,13 +92,10 @@ static void maybe_release_space(struct gfs2_bufdata *bd) rgrp_unlock_local(rgd); } -/** +/* * gfs2_unpin - Unpin a buffer * @sdp: the filesystem the buffer belongs to * @bh: The buffer to unpin - * @ai: - * @flags: The inode dirty flags - * */ static void gfs2_unpin(struct gfs2_sbd *sdp, struct buffer_head *bh, @@ -281,7 +278,7 @@ static struct bio *gfs2_log_alloc_bio(struct gfs2_sbd *sdp, u64 blkno, * gfs2_log_get_bio - Get cached log bio, or allocate a new one * @sdp: The super block * @blkno: The device block number we want to write to - * @bio: The bio to get or allocate + * @biop: The bio to get or allocate * @op: REQ_OP * @end_io: The bi_end_io callback * @flush: Always flush the current bio and allocate a new one? @@ -317,6 +314,7 @@ static struct bio *gfs2_log_get_bio(struct gfs2_sbd *sdp, u64 blkno, /** * gfs2_log_write - write to log * @sdp: the filesystem + * @jd: The journal descriptor * @page: the page to write * @size: the size of the data to write * @offset: the offset within the page @@ -417,6 +415,7 @@ static void gfs2_end_log_read(struct bio *bio) /** * gfs2_jhead_pg_srch - Look for the journal head in a given page. * @jd: The journal descriptor + * @head: the head journal to start from * @page: The page to look in * * Returns: 1 if found, 0 otherwise. @@ -450,6 +449,7 @@ static bool gfs2_jhead_pg_srch(struct gfs2_jdesc *jd, * gfs2_jhead_process_page - Search/cleanup a page * @jd: The journal descriptor * @index: Index of the page to look into + * @head: the head journal to start from * @done: If set, perform only cleanup, else search and set if found. * * Find the page with 'index' in the journal's mapping. Search the page for @@ -502,6 +502,7 @@ static struct bio *gfs2_chain_bio(struct bio *prev, unsigned int nr_iovecs) * gfs2_find_jhead - find the head of a log * @jd: The journal descriptor * @head: The log descriptor for the head of the log is returned here + * @keep_cache: If set inode pages will not be truncated * * Do a search of a journal by reading it in large chunks using bios and find * the valid log entry with the highest sequence number. (i.e. the log head) @@ -974,7 +975,7 @@ static void revoke_lo_after_scan(struct gfs2_jdesc *jd, int error, int pass) gfs2_revoke_clean(jd); } -/** +/* * databuf_lo_before_commit - Scan the data buffers, writing as we go * */ -- 2.27.0