From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Robin Murphy <robin.murphy@arm.com>
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Joerg Roedel <jroedel@suse.de>
Subject: [kbuild] drivers/gpu/drm/exynos/exynos_drm_dma.c:144 exynos_drm_register_dma() error: uninitialized symbol 'mapping'.
Date: Fri, 26 Mar 2021 14:21:12 +0300 [thread overview]
Message-ID: <20210326112112.GB1667@kadam> (raw)
[-- Attachment #1: Type: text/plain, Size: 3143 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: db24726bfefa68c606947a86132591568a06bfb4
commit: b4ceb4a5359ed1c9ba4a20acf3a70d4bbead3248 iommu: Tidy up Kconfig for SoC IOMMUs
config: nios2-randconfig-m031-20210326 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/exynos/exynos_drm_dma.c:144 exynos_drm_register_dma() error: uninitialized symbol 'mapping'.
vim +/mapping +144 drivers/gpu/drm/exynos/exynos_drm_dma.c
07dc3678bacc2a Marek Szyprowski 2020-03-09 121 int exynos_drm_register_dma(struct drm_device *drm, struct device *dev,
07dc3678bacc2a Marek Szyprowski 2020-03-09 122 void **dma_priv)
237556962e5115 Andrzej Hajda 2018-10-12 123 {
237556962e5115 Andrzej Hajda 2018-10-12 124 struct exynos_drm_private *priv = drm->dev_private;
237556962e5115 Andrzej Hajda 2018-10-12 125
237556962e5115 Andrzej Hajda 2018-10-12 126 if (!priv->dma_dev) {
237556962e5115 Andrzej Hajda 2018-10-12 127 priv->dma_dev = dev;
237556962e5115 Andrzej Hajda 2018-10-12 128 DRM_INFO("Exynos DRM: using %s device for DMA mapping operations\n",
237556962e5115 Andrzej Hajda 2018-10-12 129 dev_name(dev));
237556962e5115 Andrzej Hajda 2018-10-12 130 }
67fbf3a3ef8443 Andrzej Hajda 2018-10-12 131
67fbf3a3ef8443 Andrzej Hajda 2018-10-12 132 if (!IS_ENABLED(CONFIG_EXYNOS_IOMMU))
67fbf3a3ef8443 Andrzej Hajda 2018-10-12 133 return 0;
67fbf3a3ef8443 Andrzej Hajda 2018-10-12 134
67fbf3a3ef8443 Andrzej Hajda 2018-10-12 135 if (!priv->mapping) {
67fbf3a3ef8443 Andrzej Hajda 2018-10-12 136 void *mapping;
67fbf3a3ef8443 Andrzej Hajda 2018-10-12 137
67fbf3a3ef8443 Andrzej Hajda 2018-10-12 138 if (IS_ENABLED(CONFIG_ARM_DMA_USE_IOMMU))
67fbf3a3ef8443 Andrzej Hajda 2018-10-12 139 mapping = arm_iommu_create_mapping(&platform_bus_type,
67fbf3a3ef8443 Andrzej Hajda 2018-10-12 140 EXYNOS_DEV_ADDR_START, EXYNOS_DEV_ADDR_SIZE);
67fbf3a3ef8443 Andrzej Hajda 2018-10-12 141 else if (IS_ENABLED(CONFIG_IOMMU_DMA))
67fbf3a3ef8443 Andrzej Hajda 2018-10-12 142 mapping = iommu_get_domain_for_dev(priv->dma_dev);
67fbf3a3ef8443 Andrzej Hajda 2018-10-12 143
67fbf3a3ef8443 Andrzej Hajda 2018-10-12 @144 if (IS_ERR(mapping))
67fbf3a3ef8443 Andrzej Hajda 2018-10-12 145 return PTR_ERR(mapping);
Uninitialized in the attached .config. (I feel like I already sent
this warning. Sorry for the duplicate if so).
67fbf3a3ef8443 Andrzej Hajda 2018-10-12 146 priv->mapping = mapping;
237556962e5115 Andrzej Hajda 2018-10-12 147 }
237556962e5115 Andrzej Hajda 2018-10-12 148
07dc3678bacc2a Marek Szyprowski 2020-03-09 149 return drm_iommu_attach_device(drm, dev, dma_priv);
237556962e5115 Andrzej Hajda 2018-10-12 150 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 24679 bytes --]
[-- Attachment #3: Type: text/plain, Size: 149 bytes --]
_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-leave@lists.01.org
next reply other threads:[~2021-03-26 11:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 11:21 Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-02 7:49 [kbuild] drivers/gpu/drm/exynos/exynos_drm_dma.c:144 exynos_drm_register_dma() error: uninitialized symbol 'mapping' Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210326112112.GB1667@kadam \
--to=dan.carpenter@oracle.com \
--cc=error27@gmail.com \
--cc=jroedel@suse.de \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).