From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-mips@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Liangliang Huang <huanglllzu@gmail.com>,
Huacai Chen <chenhuacai@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Kees Cook <keescook@chromium.org>,
Jinyang He <hejinyang@loongson.cn>,
Vlastimil Babka <vbabka@suse.cz>,
Yousong Zhou <yszhou4tech@gmail.com>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
Michel Lespinasse <walken@google.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] MIPS: Add support for CONFIG_DEBUG_VIRTUAL
Date: Fri, 26 Mar 2021 22:44:45 +0100 [thread overview]
Message-ID: <20210326214445.GA19129@alpha.franken.de> (raw)
In-Reply-To: <439e06b6-d26a-e43d-1e09-c8fd41aea6ed@gmail.com>
On Fri, Mar 26, 2021 at 10:45:39AM -0700, Florian Fainelli wrote:
>
>
> On 3/25/2021 2:57 AM, Thomas Bogendoerfer wrote:
> > On Tue, Mar 23, 2021 at 03:20:43PM -0700, Florian Fainelli wrote:
> >> Provide hooks to intercept bad usages of virt_to_phys() and
> >> __pa_symbol() throughout the kernel. To make this possible, we need to
> >> rename the current implement of virt_to_phys() into
> >> __virt_to_phys_nodebug() and wrap it around depending on
> >> CONFIG_DEBUG_VIRTUAL.
> >>
> >> A similar thing is needed for __pa_symbol() which is now aliased to
> >> __phys_addr_symbol() whose implementation is either the direct return of
> >> RELOC_HIDE or goes through the debug version.
> >>
> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> >> ---
> >> Changes in v2:
> >> - fixed sparse warning in arch/mips/kernel/vdso.c
> >
> > checkpatch warns about a missing SPDX license in arch/mips/mm/physaddr.c,
> > can you please add one ?
>
> Yes.
>
> >
> > And as checkpatch is also unhappy about the volatiles, do we really
> > need them here ?
>
> This is just following the existing prototypes for virt_to_phys()
> declared in arch/mips/include/asm/io.h. This can be changed to unsigned
> long if you prefer?
I just checked other archs and they also use volatile, so nothing to
change here.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2021-03-26 21:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 22:20 [PATCH v2] MIPS: Add support for CONFIG_DEBUG_VIRTUAL Florian Fainelli
2021-03-25 9:57 ` Thomas Bogendoerfer
2021-03-26 17:45 ` Florian Fainelli
2021-03-26 21:44 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210326214445.GA19129@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=anshuman.khandual@arm.com \
--cc=chenhuacai@kernel.org \
--cc=daniel.m.jordan@oracle.com \
--cc=f.fainelli@gmail.com \
--cc=geert@linux-m68k.org \
--cc=hejinyang@loongson.cn \
--cc=huanglllzu@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=vbabka@suse.cz \
--cc=walken@google.com \
--cc=yszhou4tech@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).