From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3550C433C1 for ; Mon, 29 Mar 2021 00:39:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C526B61948 for ; Mon, 29 Mar 2021 00:39:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231626AbhC2Ait (ORCPT ); Sun, 28 Mar 2021 20:38:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:42920 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229822AbhC2AiX (ORCPT ); Sun, 28 Mar 2021 20:38:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0915161922; Mon, 29 Mar 2021 00:38:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616978300; bh=Xn0UndLnRHTcnV9w5V4XY+G1MloCRyKASA1FTEQj8G4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A2/kj0xb3cFoaVuximJ2D22pa1TqyWlIFAqQQtA7bFQhA4UowrOlJmSAn5fLRw5Bp WKvSutZAIw1kVdmSo7hirDAeLth5z0VCr9l91VsMMxy1IMUowLddMm5IUNSHPPtOcY olo9/AcjjLnUoeYeCOHrqjhauqXFQ1IZA5bc/rrOJpLEitGmdnFnZEROqX6AvBvmIp LglxPQAQth9hljlf4FjR+3RS1faE215HYSbkyjgNNmxfFZGVgu+6lNas2ydZcuEj1L vFP2ip5UmsPzNkrXW2DaptApYmvFJ4n4QrwoOhsfwdvFXouWaKCLZqGin2fKSGolxy zkhJBHVnrESzQ== Date: Mon, 29 Mar 2021 08:38:15 +0800 From: Shawn Guo To: Li Yang Cc: Michael Walle , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , lkml , Rob Herring , Sahil Malhotra , Guillaume Tucker , "kernelci.org bot" Subject: Re: [PATCH] arm64: dts: ls1028a: fix optee node Message-ID: <20210329003814.GC22955@dragon> References: <20210318083438.26536-1-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 22, 2021 at 06:12:06PM -0500, Li Yang wrote: > On Thu, Mar 18, 2021 at 3:36 AM Michael Walle wrote: > > > > Don't enable the optee node in the SoC include. It is an optional > > component and actually, if enabled, breaks boards which doesn't have it. > > Hi Shawn, > > Shall we make this a general rule? I see quite a few SoC dtsi files > are having the optee node enabled by default. Yeah, we should probably make it a general rule considering the issue reported here. I thought that optee driver is smart enough to stop probing if there is no optee os/firmware support found on given platform. Shawn