From: Alan Stern <stern@rowland.harvard.edu>
To: liulongfang <liulongfang@huawei.com>
Cc: gregkh@linuxfoundation.org, mathias.nyman@intel.com,
linux-usb@vger.kernel.org, yisen.zhuang@huawei.com,
tanxiaofei@huawei.com, liudongdong3@huawei.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] USB:ohci:fix ohci interruption problem
Date: Mon, 29 Mar 2021 11:25:44 -0400 [thread overview]
Message-ID: <20210329152544.GB933773@rowland.harvard.edu> (raw)
In-Reply-To: <e8d6fb1c-5a9b-426a-4844-add67aac768f@huawei.com>
On Mon, Mar 29, 2021 at 04:38:10PM +0800, liulongfang wrote:
> On 2021/3/26 23:28, Alan Stern wrote:
> > On Fri, Mar 26, 2021 at 04:54:56PM +0800, Longfang Liu wrote:
> >> When OHCI enters the S4 sleep state, the USB sleep process will call
> >> check_root_hub_suspend() and ohci_bus_suspend() instead of
> >> ohci_suspend() and ohci_bus_suspend(), this causes the OHCI interrupt
> >> to not be closed.
> >
> > What on earth are you talking about? This isn't true at all.
> >
> > Can you provide more information about your system? Are you using a
> > PCI-based OHCI controller or a platform device (and if so, which one)?
> > Can you post system logs to back up your statements?
> > The system is UOS, the kernel version is kernel4.19, and the driver
> used is ohci-pci.c based on PCI.
>
> By adding the log in ohci_suspend, and then viewing the dmesg after sleep,
> I can confirm that the system does not call ohci_suspend in S4 sleep mode.
Then your job is to figure out why not. Doesn't entry into S4 sleep
call hcd_pci_suspend() in core/hcd-pci.c, and doesn't that call
suspend_common(), and doesn't that call hcd->driver->pci_suspend(),
and isn't that routine ohci_suspend()?
Alan Stern
prev parent reply other threads:[~2021-03-29 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 8:54 [RFC PATCH] USB:ohci:fix ohci interruption problem Longfang Liu
2021-03-26 15:28 ` Alan Stern
2021-03-29 8:38 ` liulongfang
2021-03-29 15:25 ` Alan Stern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210329152544.GB933773@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=liulongfang@huawei.com \
--cc=mathias.nyman@intel.com \
--cc=tanxiaofei@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).