From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4929CC433DB for ; Mon, 29 Mar 2021 21:59:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D0E56188B for ; Mon, 29 Mar 2021 21:59:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230339AbhC2V6c (ORCPT ); Mon, 29 Mar 2021 17:58:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:40450 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230089AbhC2V6Q (ORCPT ); Mon, 29 Mar 2021 17:58:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8A41961481; Mon, 29 Mar 2021 21:58:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617055096; bh=ARxgytYYbc0pvxc9szjy73NYkLMwf11cpxbHeU690ek=; h=Date:From:To:Cc:Subject:From; b=h98V8oc5H1o6eE1RXoALvixBgKafkpcm1VRxrmrZ6JUKku0TJrda1xJ3kceLyC5GH qUJL+1jA1R8MU0Bc7lrZ5JSP9qGhDOzhgBT5pEo+ghLHMviMBYNWeRIaw8rR2tfkvt //2qQHgek3RMySa78iHvsFqdHpSI8ziiu30jte3k6bLXDhQsCZyay7SMsn0ej3bpLt l9caVojhwOn/b+e2vfdxlgS5sf8xb6qMWaacFIbNSBszLt54AOWuKwWdWCRQRV8MwU lkD5lxlHxqYh8ExIx1RDr4gLUIxEtYi7I2jF/ChILUnh2qG7/QL57dLeqY7TwBo8dY VHrWGDAfhA9aQ== Date: Mon, 29 Mar 2021 15:58:17 -0500 From: "Gustavo A. R. Silva" To: Jonathan Cameron , Lars-Peter Clausen Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH][next] iio: hrtimer-trigger: Fix potential integer overflow in iio_hrtimer_store_sampling_frequency Message-ID: <20210329205817.GA188755@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add suffix ULL to constant 1000 in order to avoid a potential integer overflow and give the compiler complete information about the proper arithmetic to use. Notice that this constant is being used in a context that expects an expression of type unsigned long long, but it's currently evaluated using 32-bit arithmetic. Addresses-Coverity-ID: 1503062 ("Unintentional integer overflow") Fixes: dafcf4ed8392 ("iio: hrtimer: Allow sub Hz granularity") Signed-off-by: Gustavo A. R. Silva --- drivers/iio/trigger/iio-trig-hrtimer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/trigger/iio-trig-hrtimer.c b/drivers/iio/trigger/iio-trig-hrtimer.c index 51e362f091c2..716c795d08fb 100644 --- a/drivers/iio/trigger/iio-trig-hrtimer.c +++ b/drivers/iio/trigger/iio-trig-hrtimer.c @@ -63,7 +63,7 @@ ssize_t iio_hrtimer_store_sampling_frequency(struct device *dev, if (integer < 0 || fract < 0) return -ERANGE; - val = fract + 1000 * integer; /* mHz */ + val = fract + 1000ULL * integer; /* mHz */ if (!val || val > UINT_MAX) return -EINVAL; -- 2.27.0