From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18155C433E3 for ; Mon, 29 Mar 2021 22:31:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F096D619C8 for ; Mon, 29 Mar 2021 22:31:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233110AbhC2Wbj (ORCPT ); Mon, 29 Mar 2021 18:31:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:48734 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232628AbhC2W1y (ORCPT ); Mon, 29 Mar 2021 18:27:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6DE46619DA; Mon, 29 Mar 2021 22:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617056654; bh=t2HXyKzwOQHohnpHhRKGY8i4hCGRDtJM6cvKdB+ROLI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q+kdlKIqN5JTcWnDx6GkiS3/ohTBAN1oYaM6ARAh6buNOnSpN/9jhiAD2nOT4CfZe jvB5od4KZxqJxK4XDvKqDP4a3aZQlUU2YvYuks14FVMhX4tmnEOMSqT04bDa4dhsIx caGBs+px0PKj5aHrOZ4iBulq7AqaLWMEFzwco/+jattMgRFdGNCbc8fgyBZQRN3CLA RYT5aAMkiy1uzIkkADn5PyBO2uhbMEVryqQc1dvKzgpfpZYYhjcn8rW65OK3wSKpkm 5ID1beXkDNvcFUVak76+4SP+PxuQ3b7xiU9he1t91+DdRtumeCGfHMBnD3trw84OuL mSDGCTPOtr6vg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Vincent Whitchurch , Tom Talpey , Paulo Alcantara , Steve French , Sasha Levin , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org Subject: [PATCH AUTOSEL 4.9 10/10] cifs: Silently ignore unknown oplock break handle Date: Mon, 29 Mar 2021 18:24:01 -0400 Message-Id: <20210329222401.2383930-10-sashal@kernel.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210329222401.2383930-1-sashal@kernel.org> References: <20210329222401.2383930-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vincent Whitchurch [ Upstream commit 219481a8f90ec3a5eed9638fb35609e4b1aeece7 ] Make SMB2 not print out an error when an oplock break is received for an unknown handle, similar to SMB1. The debug message which is printed for these unknown handles may also be misleading, so fix that too. The SMB2 lease break path is not affected by this patch. Without this, a program which writes to a file from one thread, and opens, reads, and writes the same file from another thread triggers the below errors several times a minute when run against a Samba server configured with "smb2 leases = no". CIFS: VFS: \\192.168.0.1 No task to wake, unknown frame received! NumMids 2 00000000: 424d53fe 00000040 00000000 00000012 .SMB@........... 00000010: 00000001 00000000 ffffffff ffffffff ................ 00000020: 00000000 00000000 00000000 00000000 ................ 00000030: 00000000 00000000 00000000 00000000 ................ Signed-off-by: Vincent Whitchurch Reviewed-by: Tom Talpey Reviewed-by: Paulo Alcantara (SUSE) Signed-off-by: Steve French Signed-off-by: Sasha Levin --- fs/cifs/smb2misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/cifs/smb2misc.c b/fs/cifs/smb2misc.c index bddb2d7b3982..075b285bbd3e 100644 --- a/fs/cifs/smb2misc.c +++ b/fs/cifs/smb2misc.c @@ -651,8 +651,8 @@ smb2_is_valid_oplock_break(char *buffer, struct TCP_Server_Info *server) } } spin_unlock(&cifs_tcp_ses_lock); - cifs_dbg(FYI, "Can not process oplock break for non-existent connection\n"); - return false; + cifs_dbg(FYI, "No file id matched, oplock break ignored\n"); + return true; } void -- 2.30.1