* [PATCH] riscv: add do_page_fault and do_trap_break into the kprobes blacklist
@ 2021-03-29 18:12 Jisheng Zhang
2021-03-30 9:21 ` Masami Hiramatsu
2021-04-12 1:09 ` Palmer Dabbelt
0 siblings, 2 replies; 3+ messages in thread
From: Jisheng Zhang @ 2021-03-29 18:12 UTC (permalink / raw)
To: Paul Walmsley, Palmer Dabbelt, Albert Ou, Masami Hiramatsu, Guo Ren
Cc: linux-riscv, linux-kernel
From: Jisheng Zhang <jszhang@kernel.org>
These two functions are used to implement the kprobes feature so they
can't be kprobed.
Fixes: c22b0bcb1dd0 ("riscv: Add kprobes supported")
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
arch/riscv/kernel/traps.c | 1 +
arch/riscv/mm/fault.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c
index 0879b5df11b9..1357abf79570 100644
--- a/arch/riscv/kernel/traps.c
+++ b/arch/riscv/kernel/traps.c
@@ -178,6 +178,7 @@ asmlinkage __visible void do_trap_break(struct pt_regs *regs)
else
die(regs, "Kernel BUG");
}
+NOKPROBE_SYMBOL(do_trap_break);
#ifdef CONFIG_GENERIC_BUG
int is_valid_bugaddr(unsigned long pc)
diff --git a/arch/riscv/mm/fault.c b/arch/riscv/mm/fault.c
index 8f17519208c7..c5dbd55cbf7c 100644
--- a/arch/riscv/mm/fault.c
+++ b/arch/riscv/mm/fault.c
@@ -328,3 +328,4 @@ asmlinkage void do_page_fault(struct pt_regs *regs)
}
return;
}
+NOKPROBE_SYMBOL(do_page_fault);
--
2.31.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: add do_page_fault and do_trap_break into the kprobes blacklist
2021-03-29 18:12 [PATCH] riscv: add do_page_fault and do_trap_break into the kprobes blacklist Jisheng Zhang
@ 2021-03-30 9:21 ` Masami Hiramatsu
2021-04-12 1:09 ` Palmer Dabbelt
1 sibling, 0 replies; 3+ messages in thread
From: Masami Hiramatsu @ 2021-03-30 9:21 UTC (permalink / raw)
To: Jisheng Zhang
Cc: Paul Walmsley, Palmer Dabbelt, Albert Ou, Guo Ren, linux-riscv,
linux-kernel
On Tue, 30 Mar 2021 02:12:26 +0800
Jisheng Zhang <jszhang3@mail.ustc.edu.cn> wrote:
> From: Jisheng Zhang <jszhang@kernel.org>
>
> These two functions are used to implement the kprobes feature so they
> can't be kprobed.
>
Looks good to me.
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks,
> Fixes: c22b0bcb1dd0 ("riscv: Add kprobes supported")
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
> arch/riscv/kernel/traps.c | 1 +
> arch/riscv/mm/fault.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c
> index 0879b5df11b9..1357abf79570 100644
> --- a/arch/riscv/kernel/traps.c
> +++ b/arch/riscv/kernel/traps.c
> @@ -178,6 +178,7 @@ asmlinkage __visible void do_trap_break(struct pt_regs *regs)
> else
> die(regs, "Kernel BUG");
> }
> +NOKPROBE_SYMBOL(do_trap_break);
>
> #ifdef CONFIG_GENERIC_BUG
> int is_valid_bugaddr(unsigned long pc)
> diff --git a/arch/riscv/mm/fault.c b/arch/riscv/mm/fault.c
> index 8f17519208c7..c5dbd55cbf7c 100644
> --- a/arch/riscv/mm/fault.c
> +++ b/arch/riscv/mm/fault.c
> @@ -328,3 +328,4 @@ asmlinkage void do_page_fault(struct pt_regs *regs)
> }
> return;
> }
> +NOKPROBE_SYMBOL(do_page_fault);
> --
> 2.31.0
>
>
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: add do_page_fault and do_trap_break into the kprobes blacklist
2021-03-29 18:12 [PATCH] riscv: add do_page_fault and do_trap_break into the kprobes blacklist Jisheng Zhang
2021-03-30 9:21 ` Masami Hiramatsu
@ 2021-04-12 1:09 ` Palmer Dabbelt
1 sibling, 0 replies; 3+ messages in thread
From: Palmer Dabbelt @ 2021-04-12 1:09 UTC (permalink / raw)
To: jszhang3; +Cc: Paul Walmsley, aou, mhiramat, guoren, linux-riscv, linux-kernel
On Mon, 29 Mar 2021 11:12:26 PDT (-0700), jszhang3@mail.ustc.edu.cn wrote:
> From: Jisheng Zhang <jszhang@kernel.org>
>
> These two functions are used to implement the kprobes feature so they
> can't be kprobed.
>
> Fixes: c22b0bcb1dd0 ("riscv: Add kprobes supported")
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
> arch/riscv/kernel/traps.c | 1 +
> arch/riscv/mm/fault.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c
> index 0879b5df11b9..1357abf79570 100644
> --- a/arch/riscv/kernel/traps.c
> +++ b/arch/riscv/kernel/traps.c
> @@ -178,6 +178,7 @@ asmlinkage __visible void do_trap_break(struct pt_regs *regs)
> else
> die(regs, "Kernel BUG");
> }
> +NOKPROBE_SYMBOL(do_trap_break);
>
> #ifdef CONFIG_GENERIC_BUG
> int is_valid_bugaddr(unsigned long pc)
> diff --git a/arch/riscv/mm/fault.c b/arch/riscv/mm/fault.c
> index 8f17519208c7..c5dbd55cbf7c 100644
> --- a/arch/riscv/mm/fault.c
> +++ b/arch/riscv/mm/fault.c
> @@ -328,3 +328,4 @@ asmlinkage void do_page_fault(struct pt_regs *regs)
> }
> return;
> }
> +NOKPROBE_SYMBOL(do_page_fault);
Thanks, this is on fixes.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-12 1:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-29 18:12 [PATCH] riscv: add do_page_fault and do_trap_break into the kprobes blacklist Jisheng Zhang
2021-03-30 9:21 ` Masami Hiramatsu
2021-04-12 1:09 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).