From: Mark Brown <broonie@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Zev Weiss <zev@bewilderbeest.net>,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, Andrew Jeffery <andrew@aj.id.au>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org
Subject: Re: Enabling pmbus power control
Date: Tue, 30 Mar 2021 12:22:54 +0100 [thread overview]
Message-ID: <20210330112254.GB4976@sirena.org.uk> (raw)
In-Reply-To: <5105ada1-643a-8e58-a52d-d3c8dbef86b9@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]
On Tue, Mar 30, 2021 at 03:34:16AM -0700, Guenter Roeck wrote:
> (and I don't know if the userspace consumer code is appropriate - you
> might want to check with the regulator maintainer on that).
It's not, you should never see this in a production system.
> > first attempt at this ran into problems with all the
> > reg-userspace-consumer instances getting attached to the first
> > regulator device, I think due to all of the regulators ending up under
> > the same name in the global namespace of regulator_map_list. I worked
> > around that by adding an ID counter to produce a unique name for each,
> > though that changes device names in userspace-visible ways that I'm
> > not sure would be considered OK for backwards compatibility. (I'm not
> > familiar enough with the regulator code to know if there's a better
> > way of fixing that problem.) The #if-ing to keep it behind a Kconfig
> Maybe ask that question on the regulator mailing list.
I can't really tell what the issue is here without more context, the
global name list should not be relevant for much in a system that's well
configured so it sounds like it's user error.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-30 11:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 8:17 Enabling pmbus power control Zev Weiss
2021-03-30 10:34 ` Guenter Roeck
2021-03-30 11:22 ` Mark Brown [this message]
2021-03-30 17:19 ` Zev Weiss
2021-03-30 17:42 ` Mark Brown
2021-03-30 17:56 ` Zev Weiss
2021-03-30 18:02 ` Mark Brown
2021-03-30 19:38 ` Guenter Roeck
2021-04-20 1:29 ` Zev Weiss
2021-04-20 3:36 ` Guenter Roeck
2021-04-20 5:50 ` Zev Weiss
2021-04-20 6:00 ` Guenter Roeck
2021-04-20 7:06 ` Zev Weiss
2021-04-20 10:52 ` Guenter Roeck
2021-04-20 15:19 ` Zev Weiss
2021-04-20 16:13 ` Mark Brown
2021-04-20 16:40 ` Zev Weiss
2021-04-20 17:15 ` Mark Brown
2021-04-20 18:54 ` Zev Weiss
2021-04-21 11:05 ` Mark Brown
2021-04-21 18:29 ` Zev Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330112254.GB4976@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andrew@aj.id.au \
--cc=jdelvare@suse.com \
--cc=lgirdwood@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).