From: Zhang Jianhua <zhangjianhua18@huawei.com>
To: <ath9k-devel@qca.qualcomm.com>, <kvalo@codeaurora.org>,
<davem@davemloft.net>, <kuba@kernel.org>,
<zhangjianhua18@huawei.com>
Cc: <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <johnny.chenyi@huawei.com>
Subject: [PATCH -next v2] drivers: net: CONFIG_ATH9K select LEDS_CLASS and NEW_LEDS
Date: Tue, 30 Mar 2021 20:05:33 +0800 [thread overview]
Message-ID: <20210330120533.102712-1-zhangjianhua18@huawei.com> (raw)
If CONFIG_ATH9K=y, the following errors will be seen while compiling
gpio.c
drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_deinit_leds':
gpio.c:(.text+0x604): undefined reference to `led_classdev_unregister'
gpio.c:(.text+0x604): relocation truncated to fit: R_AARCH64_CALL26
against undefined symbol `led_classdev_unregister'
drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_init_leds':
gpio.c:(.text+0x708): undefined reference to `led_classdev_register_ext'
gpio.c:(.text+0x708): relocation truncated to fit: R_AARCH64_CALL26
against undefined symbol `led_classdev_register_ext'
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Jianhua <zhangjianhua18@huawei.com>
---
v2:
add 'select NEW_LEDS'
---
drivers/net/wireless/ath/ath9k/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/ath/ath9k/Kconfig b/drivers/net/wireless/ath/ath9k/Kconfig
index e150d82eddb6..0a73ede3148a 100644
--- a/drivers/net/wireless/ath/ath9k/Kconfig
+++ b/drivers/net/wireless/ath/ath9k/Kconfig
@@ -24,6 +24,8 @@ config ATH9K
select MAC80211_LEDS if LEDS_CLASS=y || LEDS_CLASS=MAC80211
select ATH9K_HW
select ATH9K_COMMON
+ select NEW_LEDS
+ select LEDS_CLASS
help
This module adds support for wireless adapters based on
Atheros IEEE 802.11n AR5008, AR9001 and AR9002 family
--
2.17.1
next reply other threads:[~2021-03-30 12:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 12:05 Zhang Jianhua [this message]
2021-04-22 13:42 ` [PATCH -next v2] drivers: net: CONFIG_ATH9K select LEDS_CLASS and NEW_LEDS Kalle Valo
2021-05-15 6:35 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330120533.102712-1-zhangjianhua18@huawei.com \
--to=zhangjianhua18@huawei.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=davem@davemloft.net \
--cc=johnny.chenyi@huawei.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).