* [PATCH] memory: pl353: fix macro definition of ecc page_size for arm pl353 static memory controller
@ 2021-03-31 3:10 gexueyuan
2021-04-05 14:17 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: gexueyuan @ 2021-03-31 3:10 UTC (permalink / raw)
To: krzk; +Cc: linux-kernel, gexueyuan
the macro "PL353_SMC_ECC_MEMCFG_PGSIZE_MASK" should be 0x3,
according to the datasheet of pl353 smc
Signed-off-by: gexueyuan <gexueyuan@gmail.com>
---
drivers/memory/pl353-smc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/memory/pl353-smc.c b/drivers/memory/pl353-smc.c
index 3b5b1045edd9..9c0a28416777 100644
--- a/drivers/memory/pl353-smc.c
+++ b/drivers/memory/pl353-smc.c
@@ -63,7 +63,7 @@
/* ECC memory config register specific constants */
#define PL353_SMC_ECC_MEMCFG_MODE_MASK 0xC
#define PL353_SMC_ECC_MEMCFG_MODE_SHIFT 2
-#define PL353_SMC_ECC_MEMCFG_PGSIZE_MASK 0xC
+#define PL353_SMC_ECC_MEMCFG_PGSIZE_MASK 0x3
#define PL353_SMC_DC_UPT_NAND_REGS ((4 << 23) | /* CS: NAND chip */ \
(2 << 21)) /* UpdateRegs operation */
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] memory: pl353: fix macro definition of ecc page_size for arm pl353 static memory controller
2021-03-31 3:10 [PATCH] memory: pl353: fix macro definition of ecc page_size for arm pl353 static memory controller gexueyuan
@ 2021-04-05 14:17 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-04-05 14:17 UTC (permalink / raw)
To: krzk, gexueyuan; +Cc: Krzysztof Kozlowski, linux-kernel
On Wed, 31 Mar 2021 11:10:56 +0800, gexueyuan wrote:
> the macro "PL353_SMC_ECC_MEMCFG_PGSIZE_MASK" should be 0x3,
> according to the datasheet of pl353 smc
Applied, with fixes in commit msg and adding Fixes tag. Please do not forget
about Fixes tag and start new sentences with capital letter. Thanks.
[1/1] memory: pl353: fix macro definition of ecc page_size for arm pl353 static memory controller
commit: 25dcca7fedcd4e31cb368ad846bfd738c0c6307c
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-05 14:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31 3:10 [PATCH] memory: pl353: fix macro definition of ecc page_size for arm pl353 static memory controller gexueyuan
2021-04-05 14:17 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).