* [PATCH] mfd: abx500: Remove repeated struct declaration
@ 2021-04-01 9:30 Wan Jiabing
2021-04-14 8:43 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Wan Jiabing @ 2021-04-01 9:30 UTC (permalink / raw)
To: linux-kernel; +Cc: kael_w, Wan Jiabing
struct ab8500_fg is declared twice. The blew one at 457th line
is closer to user. Remove the duplicate here.
Move "Forward declaration" annotation to the suitable place.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
include/linux/mfd/abx500/ab8500-bm.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/include/linux/mfd/abx500/ab8500-bm.h b/include/linux/mfd/abx500/ab8500-bm.h
index 903e94c189d8..0b88eddcc5af 100644
--- a/include/linux/mfd/abx500/ab8500-bm.h
+++ b/include/linux/mfd/abx500/ab8500-bm.h
@@ -296,9 +296,6 @@ struct batres_vs_temp {
int resist;
};
-/* Forward declaration */
-struct ab8500_fg;
-
/**
* struct ab8500_fg_parameters - Fuel gauge algorithm parameters, in seconds
* if not specified
@@ -452,6 +449,7 @@ struct ab8500_bm_data {
const struct ab8500_fg_parameters *fg_params;
};
+/* Forward declaration */
struct ab8500_btemp;
struct ab8500_gpadc;
struct ab8500_fg;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: abx500: Remove repeated struct declaration
2021-04-01 9:30 [PATCH] mfd: abx500: Remove repeated struct declaration Wan Jiabing
@ 2021-04-14 8:43 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2021-04-14 8:43 UTC (permalink / raw)
To: Wan Jiabing; +Cc: linux-kernel, kael_w
On Thu, 01 Apr 2021, Wan Jiabing wrote:
> struct ab8500_fg is declared twice. The blew one at 457th line
> is closer to user. Remove the duplicate here.
> Move "Forward declaration" annotation to the suitable place.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> include/linux/mfd/abx500/ab8500-bm.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Please check, but I don't think this patch is valid anymore.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-14 8:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01 9:30 [PATCH] mfd: abx500: Remove repeated struct declaration Wan Jiabing
2021-04-14 8:43 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).