linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] iio: adc: stm32-dfsdm: drop __func__ while using Dynamic debug
@ 2021-04-01 15:43 Mugilraj Dhavachelvan
  2021-04-01 18:05 ` Andy Shevchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Mugilraj Dhavachelvan @ 2021-04-01 15:43 UTC (permalink / raw)
  To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
	Peter Meerwald-Stadler, Maxime Coquelin, Alexandre Torgue,
	Mugilraj Dhavachelvan, linux-iio, linux-stm32, linux-arm-kernel,
	linux-kernel

dropped __func__ while using dev_dbg() and pr_debug()

Signed-off-by: Mugilraj Dhavachelvan <dmugil2000@gmail.com>
---
 drivers/iio/adc/stm32-dfsdm-adc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
index 76a60d93fe23..95ec5f3c3126 100644
--- a/drivers/iio/adc/stm32-dfsdm-adc.c
+++ b/drivers/iio/adc/stm32-dfsdm-adc.c
@@ -198,7 +198,7 @@ static int stm32_dfsdm_compute_osrs(struct stm32_dfsdm_filter *fl,
 	unsigned int p = fl->ford;	/* filter order (ford) */
 	struct stm32_dfsdm_filter_osr *flo = &fl->flo[fast];
 
-	pr_debug("%s: Requested oversampling: %d\n",  __func__, oversamp);
+	pr_debug("Requested oversampling: %d\n", oversamp);
 	/*
 	 * This function tries to compute filter oversampling and integrator
 	 * oversampling, base on oversampling ratio requested by user.
@@ -294,8 +294,8 @@ static int stm32_dfsdm_compute_osrs(struct stm32_dfsdm_filter *fl,
 				}
 				flo->max = (s32)max;
 
-				pr_debug("%s: fast %d, fosr %d, iosr %d, res 0x%llx/%d bits, rshift %d, lshift %d\n",
-					 __func__, fast, flo->fosr, flo->iosr,
+				pr_debug("fast %d, fosr %d, iosr %d, res 0x%llx/%d bits, rshift %d, lshift %d\n",
+					 fast, flo->fosr, flo->iosr,
 					 flo->res, bits, flo->rshift,
 					 flo->lshift);
 			}
@@ -858,7 +858,7 @@ static void stm32_dfsdm_dma_buffer_done(void *data)
 	 * support in IIO.
 	 */
 
-	dev_dbg(&indio_dev->dev, "%s: pos = %d, available = %d\n", __func__,
+	dev_dbg(&indio_dev->dev, "pos = %d, available = %d\n",
 		adc->bufi, available);
 	old_pos = adc->bufi;
 
@@ -912,7 +912,7 @@ static int stm32_dfsdm_adc_dma_start(struct iio_dev *indio_dev)
 	if (!adc->dma_chan)
 		return -EINVAL;
 
-	dev_dbg(&indio_dev->dev, "%s size=%d watermark=%d\n", __func__,
+	dev_dbg(&indio_dev->dev, "size=%d watermark=%d\n",
 		adc->buf_sz, adc->buf_sz / 2);
 
 	if (adc->nconv == 1 && !indio_dev->trig)
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: stm32-dfsdm: drop __func__ while using Dynamic debug
  2021-04-01 15:43 [PATCH] iio: adc: stm32-dfsdm: drop __func__ while using Dynamic debug Mugilraj Dhavachelvan
@ 2021-04-01 18:05 ` Andy Shevchenko
  2021-04-02  9:53   ` Jonathan Cameron
  0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2021-04-01 18:05 UTC (permalink / raw)
  To: Mugilraj Dhavachelvan
  Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
	Peter Meerwald-Stadler, Maxime Coquelin, Alexandre Torgue,
	linux-iio, linux-stm32, linux-arm Mailing List,
	Linux Kernel Mailing List

On Thu, Apr 1, 2021 at 8:48 PM Mugilraj Dhavachelvan
<dmugil2000@gmail.com> wrote:
>
> dropped __func__ while using dev_dbg() and pr_debug()

The commit message may be amended, from code perspective LGTM!
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Mugilraj Dhavachelvan <dmugil2000@gmail.com>
> ---
>  drivers/iio/adc/stm32-dfsdm-adc.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> index 76a60d93fe23..95ec5f3c3126 100644
> --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> @@ -198,7 +198,7 @@ static int stm32_dfsdm_compute_osrs(struct stm32_dfsdm_filter *fl,
>         unsigned int p = fl->ford;      /* filter order (ford) */
>         struct stm32_dfsdm_filter_osr *flo = &fl->flo[fast];
>
> -       pr_debug("%s: Requested oversampling: %d\n",  __func__, oversamp);
> +       pr_debug("Requested oversampling: %d\n", oversamp);
>         /*
>          * This function tries to compute filter oversampling and integrator
>          * oversampling, base on oversampling ratio requested by user.
> @@ -294,8 +294,8 @@ static int stm32_dfsdm_compute_osrs(struct stm32_dfsdm_filter *fl,
>                                 }
>                                 flo->max = (s32)max;
>
> -                               pr_debug("%s: fast %d, fosr %d, iosr %d, res 0x%llx/%d bits, rshift %d, lshift %d\n",
> -                                        __func__, fast, flo->fosr, flo->iosr,
> +                               pr_debug("fast %d, fosr %d, iosr %d, res 0x%llx/%d bits, rshift %d, lshift %d\n",
> +                                        fast, flo->fosr, flo->iosr,
>                                          flo->res, bits, flo->rshift,
>                                          flo->lshift);
>                         }
> @@ -858,7 +858,7 @@ static void stm32_dfsdm_dma_buffer_done(void *data)
>          * support in IIO.
>          */
>
> -       dev_dbg(&indio_dev->dev, "%s: pos = %d, available = %d\n", __func__,
> +       dev_dbg(&indio_dev->dev, "pos = %d, available = %d\n",
>                 adc->bufi, available);
>         old_pos = adc->bufi;
>
> @@ -912,7 +912,7 @@ static int stm32_dfsdm_adc_dma_start(struct iio_dev *indio_dev)
>         if (!adc->dma_chan)
>                 return -EINVAL;
>
> -       dev_dbg(&indio_dev->dev, "%s size=%d watermark=%d\n", __func__,
> +       dev_dbg(&indio_dev->dev, "size=%d watermark=%d\n",
>                 adc->buf_sz, adc->buf_sz / 2);
>
>         if (adc->nconv == 1 && !indio_dev->trig)
> --
> 2.25.1
>


-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: stm32-dfsdm: drop __func__ while using Dynamic debug
  2021-04-01 18:05 ` Andy Shevchenko
@ 2021-04-02  9:53   ` Jonathan Cameron
  0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2021-04-02  9:53 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Mugilraj Dhavachelvan, Hartmut Knaack, Lars-Peter Clausen,
	Peter Meerwald-Stadler, Maxime Coquelin, Alexandre Torgue,
	linux-iio, linux-stm32, linux-arm Mailing List,
	Linux Kernel Mailing List

On Thu, 1 Apr 2021 21:05:58 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Thu, Apr 1, 2021 at 8:48 PM Mugilraj Dhavachelvan
> <dmugil2000@gmail.com> wrote:
> >
> > dropped __func__ while using dev_dbg() and pr_debug()  
> 
> The commit message may be amended, from code perspective LGTM!
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

I added a note to the commit message to observe that the function
name printing can be configured using dynamic debug.

Applied to the togreg branch of iio.git and pushed out as testing
to let the autobuilder bots like 0-day check if they can find any
problems that we've missed.

Thanks,

Jonathan

> 
> > Signed-off-by: Mugilraj Dhavachelvan <dmugil2000@gmail.com>
> > ---
> >  drivers/iio/adc/stm32-dfsdm-adc.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> > index 76a60d93fe23..95ec5f3c3126 100644
> > --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> > @@ -198,7 +198,7 @@ static int stm32_dfsdm_compute_osrs(struct stm32_dfsdm_filter *fl,
> >         unsigned int p = fl->ford;      /* filter order (ford) */
> >         struct stm32_dfsdm_filter_osr *flo = &fl->flo[fast];
> >
> > -       pr_debug("%s: Requested oversampling: %d\n",  __func__, oversamp);
> > +       pr_debug("Requested oversampling: %d\n", oversamp);
> >         /*
> >          * This function tries to compute filter oversampling and integrator
> >          * oversampling, base on oversampling ratio requested by user.
> > @@ -294,8 +294,8 @@ static int stm32_dfsdm_compute_osrs(struct stm32_dfsdm_filter *fl,
> >                                 }
> >                                 flo->max = (s32)max;
> >
> > -                               pr_debug("%s: fast %d, fosr %d, iosr %d, res 0x%llx/%d bits, rshift %d, lshift %d\n",
> > -                                        __func__, fast, flo->fosr, flo->iosr,
> > +                               pr_debug("fast %d, fosr %d, iosr %d, res 0x%llx/%d bits, rshift %d, lshift %d\n",
> > +                                        fast, flo->fosr, flo->iosr,
> >                                          flo->res, bits, flo->rshift,
> >                                          flo->lshift);
> >                         }
> > @@ -858,7 +858,7 @@ static void stm32_dfsdm_dma_buffer_done(void *data)
> >          * support in IIO.
> >          */
> >
> > -       dev_dbg(&indio_dev->dev, "%s: pos = %d, available = %d\n", __func__,
> > +       dev_dbg(&indio_dev->dev, "pos = %d, available = %d\n",
> >                 adc->bufi, available);
> >         old_pos = adc->bufi;
> >
> > @@ -912,7 +912,7 @@ static int stm32_dfsdm_adc_dma_start(struct iio_dev *indio_dev)
> >         if (!adc->dma_chan)
> >                 return -EINVAL;
> >
> > -       dev_dbg(&indio_dev->dev, "%s size=%d watermark=%d\n", __func__,
> > +       dev_dbg(&indio_dev->dev, "size=%d watermark=%d\n",
> >                 adc->buf_sz, adc->buf_sz / 2);
> >
> >         if (adc->nconv == 1 && !indio_dev->trig)
> > --
> > 2.25.1
> >  
> 
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-02  9:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01 15:43 [PATCH] iio: adc: stm32-dfsdm: drop __func__ while using Dynamic debug Mugilraj Dhavachelvan
2021-04-01 18:05 ` Andy Shevchenko
2021-04-02  9:53   ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).