* [PATCH] ARM: OMAP1: ams-delta: remove unused function ams_delta_camera_power
@ 2021-04-01 16:04 Maciej Falkowski
2021-04-01 16:37 ` Nathan Chancellor
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Maciej Falkowski @ 2021-04-01 16:04 UTC (permalink / raw)
To: aaro.koskinen, tony, linux
Cc: linux-omap, linux-arm-kernel, linux-kernel, clang-built-linux,
maciej.falkowski9
The ams_delta_camera_power() function is unused as reports
Clang compilation with omap1_defconfig on linux-next:
arch/arm/mach-omap1/board-ams-delta.c:462:12: warning: unused function 'ams_delta_camera_power' [-Wunused-function]
static int ams_delta_camera_power(struct device *dev, int power)
^
1 warning generated.
The soc_camera support was dropped without removing
ams_delta_camera_power() function, making it unused.
Signed-off-by: Maciej Falkowski <maciej.falkowski9@gmail.com>
Fixes: ce548396a433 ("media: mach-omap1: board-ams-delta.c: remove soc_camera dependencies")
Link: https://github.com/ClangBuiltLinux/linux/issues/1326
---
arch/arm/mach-omap1/board-ams-delta.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/arch/arm/mach-omap1/board-ams-delta.c b/arch/arm/mach-omap1/board-ams-delta.c
index 2ee527c00284..1026a816dcc0 100644
--- a/arch/arm/mach-omap1/board-ams-delta.c
+++ b/arch/arm/mach-omap1/board-ams-delta.c
@@ -458,20 +458,6 @@ static struct gpiod_lookup_table leds_gpio_table = {
#ifdef CONFIG_LEDS_TRIGGERS
DEFINE_LED_TRIGGER(ams_delta_camera_led_trigger);
-
-static int ams_delta_camera_power(struct device *dev, int power)
-{
- /*
- * turn on camera LED
- */
- if (power)
- led_trigger_event(ams_delta_camera_led_trigger, LED_FULL);
- else
- led_trigger_event(ams_delta_camera_led_trigger, LED_OFF);
- return 0;
-}
-#else
-#define ams_delta_camera_power NULL
#endif
static struct platform_device ams_delta_audio_device = {
--
2.26.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP1: ams-delta: remove unused function ams_delta_camera_power
2021-04-01 16:04 [PATCH] ARM: OMAP1: ams-delta: remove unused function ams_delta_camera_power Maciej Falkowski
@ 2021-04-01 16:37 ` Nathan Chancellor
2021-04-01 18:55 ` Nick Desaulniers
2021-05-26 11:03 ` Tony Lindgren
2 siblings, 0 replies; 4+ messages in thread
From: Nathan Chancellor @ 2021-04-01 16:37 UTC (permalink / raw)
To: Maciej Falkowski
Cc: aaro.koskinen, tony, linux, linux-omap, linux-arm-kernel,
linux-kernel, clang-built-linux
On Thu, Apr 01, 2021 at 06:04:34PM +0200, Maciej Falkowski wrote:
> The ams_delta_camera_power() function is unused as reports
> Clang compilation with omap1_defconfig on linux-next:
>
> arch/arm/mach-omap1/board-ams-delta.c:462:12: warning: unused function 'ams_delta_camera_power' [-Wunused-function]
> static int ams_delta_camera_power(struct device *dev, int power)
> ^
> 1 warning generated.
>
> The soc_camera support was dropped without removing
> ams_delta_camera_power() function, making it unused.
>
> Signed-off-by: Maciej Falkowski <maciej.falkowski9@gmail.com>
> Fixes: ce548396a433 ("media: mach-omap1: board-ams-delta.c: remove soc_camera dependencies")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1326
Thanks for the patch!
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> arch/arm/mach-omap1/board-ams-delta.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/board-ams-delta.c b/arch/arm/mach-omap1/board-ams-delta.c
> index 2ee527c00284..1026a816dcc0 100644
> --- a/arch/arm/mach-omap1/board-ams-delta.c
> +++ b/arch/arm/mach-omap1/board-ams-delta.c
> @@ -458,20 +458,6 @@ static struct gpiod_lookup_table leds_gpio_table = {
>
> #ifdef CONFIG_LEDS_TRIGGERS
> DEFINE_LED_TRIGGER(ams_delta_camera_led_trigger);
> -
> -static int ams_delta_camera_power(struct device *dev, int power)
> -{
> - /*
> - * turn on camera LED
> - */
> - if (power)
> - led_trigger_event(ams_delta_camera_led_trigger, LED_FULL);
> - else
> - led_trigger_event(ams_delta_camera_led_trigger, LED_OFF);
> - return 0;
> -}
> -#else
> -#define ams_delta_camera_power NULL
> #endif
>
> static struct platform_device ams_delta_audio_device = {
> --
> 2.26.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP1: ams-delta: remove unused function ams_delta_camera_power
2021-04-01 16:04 [PATCH] ARM: OMAP1: ams-delta: remove unused function ams_delta_camera_power Maciej Falkowski
2021-04-01 16:37 ` Nathan Chancellor
@ 2021-04-01 18:55 ` Nick Desaulniers
2021-05-26 11:03 ` Tony Lindgren
2 siblings, 0 replies; 4+ messages in thread
From: Nick Desaulniers @ 2021-04-01 18:55 UTC (permalink / raw)
To: Maciej Falkowski
Cc: aaro.koskinen, tony, Russell King, linux-omap, Linux ARM, LKML,
clang-built-linux
On Thu, Apr 1, 2021 at 9:05 AM Maciej Falkowski
<maciej.falkowski9@gmail.com> wrote:
>
> The ams_delta_camera_power() function is unused as reports
> Clang compilation with omap1_defconfig on linux-next:
>
> arch/arm/mach-omap1/board-ams-delta.c:462:12: warning: unused function 'ams_delta_camera_power' [-Wunused-function]
> static int ams_delta_camera_power(struct device *dev, int power)
> ^
> 1 warning generated.
>
> The soc_camera support was dropped without removing
> ams_delta_camera_power() function, making it unused.
>
> Signed-off-by: Maciej Falkowski <maciej.falkowski9@gmail.com>
Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> Fixes: ce548396a433 ("media: mach-omap1: board-ams-delta.c: remove soc_camera dependencies")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1326
> ---
> arch/arm/mach-omap1/board-ams-delta.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/board-ams-delta.c b/arch/arm/mach-omap1/board-ams-delta.c
> index 2ee527c00284..1026a816dcc0 100644
> --- a/arch/arm/mach-omap1/board-ams-delta.c
> +++ b/arch/arm/mach-omap1/board-ams-delta.c
> @@ -458,20 +458,6 @@ static struct gpiod_lookup_table leds_gpio_table = {
>
> #ifdef CONFIG_LEDS_TRIGGERS
> DEFINE_LED_TRIGGER(ams_delta_camera_led_trigger);
> -
> -static int ams_delta_camera_power(struct device *dev, int power)
> -{
> - /*
> - * turn on camera LED
> - */
> - if (power)
> - led_trigger_event(ams_delta_camera_led_trigger, LED_FULL);
> - else
> - led_trigger_event(ams_delta_camera_led_trigger, LED_OFF);
> - return 0;
> -}
> -#else
> -#define ams_delta_camera_power NULL
> #endif
>
> static struct platform_device ams_delta_audio_device = {
> --
> 2.26.3
>
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20210401160434.7655-1-maciej.falkowski9%40gmail.com.
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP1: ams-delta: remove unused function ams_delta_camera_power
2021-04-01 16:04 [PATCH] ARM: OMAP1: ams-delta: remove unused function ams_delta_camera_power Maciej Falkowski
2021-04-01 16:37 ` Nathan Chancellor
2021-04-01 18:55 ` Nick Desaulniers
@ 2021-05-26 11:03 ` Tony Lindgren
2 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2021-05-26 11:03 UTC (permalink / raw)
To: Maciej Falkowski
Cc: aaro.koskinen, linux, linux-omap, linux-arm-kernel, linux-kernel,
clang-built-linux
* Maciej Falkowski <maciej.falkowski9@gmail.com> [210401 19:06]:
> The ams_delta_camera_power() function is unused as reports
> Clang compilation with omap1_defconfig on linux-next:
>
> arch/arm/mach-omap1/board-ams-delta.c:462:12: warning: unused function 'ams_delta_camera_power' [-Wunused-function]
> static int ams_delta_camera_power(struct device *dev, int power)
> ^
> 1 warning generated.
>
> The soc_camera support was dropped without removing
> ams_delta_camera_power() function, making it unused.
>
> Signed-off-by: Maciej Falkowski <maciej.falkowski9@gmail.com>
> Fixes: ce548396a433 ("media: mach-omap1: board-ams-delta.c: remove soc_camera dependencies")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1326
Thanks applying into fixes.
Regards,
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-26 11:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01 16:04 [PATCH] ARM: OMAP1: ams-delta: remove unused function ams_delta_camera_power Maciej Falkowski
2021-04-01 16:37 ` Nathan Chancellor
2021-04-01 18:55 ` Nick Desaulniers
2021-05-26 11:03 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).