From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: gregkh@linuxfoundation.org, dan.carpenter@oracle.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/16] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.c
Date: Sat, 3 Apr 2021 09:29:34 +0200 [thread overview]
Message-ID: <20210403072933.GA1563@agape.jhs> (raw)
In-Reply-To: <906c8d899a3840afab1e624736b44292eacc6c97.camel@perches.com>
On Fri, Apr 02, 2021 at 11:37:17AM -0700, Joe Perches wrote:
> On Fri, 2021-04-02 at 19:40 +0200, Fabio Aiuto wrote:
> > On Fri, Apr 02, 2021 at 08:20:17AM -0700, Joe Perches wrote:
> > > On Fri, 2021-04-02 at 14:51 +0200, Fabio Aiuto wrote:
> > > > On Fri, Apr 02, 2021 at 03:37:57AM -0700, Joe Perches wrote:
> > > > > On Fri, 2021-04-02 at 12:01 +0200, Fabio Aiuto wrote:
> > > > > > remove all RT_TRACE logs
> > > > > >
> > > > > > fix patch-related checkpatch issues
> []
> > > > > Lastly, another suggestion would be to just submit a single patch
> > > > > removing _ALL_ the RT_TRACE uses not intermixing various other cleanups
> > > > > with the series and then do those other cleanups.
> > > > >
> > > > > Using a coccinelle script like:
> > > > >
> > > > > $ cat RT_TRACE.cocci
> > > > > @@
> > > > > expression a, b, c;
> > > > > @@
> > > > >
> > > > > - RT_TRACE(a, b, (c));
> > > > >
> > > > > $ spatch -sp-file RT_TRACE.cocci drivers/staging/rtl8723bs/
> > > > >
> > > > > And then clean up the various bits you think are inappropriately done.
> []
> > > > thank you Joe, I tried with (RT_TRACE.cocci in parent folder)
> > > >
> > > > user@host:~/src/git/kernels/staging$ spatch -sp-file ../RT_TRACE.cocci drivers/staging/rtl8723bs/
> > > > init_defs_builtins: /usr/local/bin/../lib/coccinelle/standard.h
> > > > 0 files match
> > >
> > > Likely you are running the script on the tree after you have
> > > applied all your patches.
> > >
> > > Try running the cocci script on a fresh copy of -next.
> > >
> > > Using the script and adding the script in the commit message helps
> > > others to verify that the changes you make do not have any other effect.
> > >
> > > $ cat RT_TRACE.cocci
> > > @@
> > > expression a, b, c;
> > > @@
> > >
> > > - RT_TRACE(a, b, (c));
> > >
> > > $ git checkout next-20210401
> > > $ spatch -sp-file RT_TRACE.cocci --in-place --no-show-diff --very-quiet drivers/staging/rtl8723bs/
> > > 31 files match
> > > $ git diff --stat -p
> > > drivers/staging/rtl8723bs/core/rtw_cmd.c | 34 +------
> []
> > > 28 files changed, 19 insertions(+), 935 deletions(-)
> []
> > thank you Joe, this mail is so precious ;)
>
> I'm not quite sure what you mean by that but you quoted
> nearly 200k of the previous email.
you gave me good advice
>
> Please remember to trim your replies.
>
>
got it, thank you
regards,
fabio
next prev parent reply other threads:[~2021-04-03 7:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 10:01 [PATCH 00/16] staging: rtl8723bs: remove RT_TRACE logs in core/* Fabio Aiuto
2021-04-02 10:01 ` [PATCH 01/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c Fabio Aiuto
2021-04-02 11:56 ` Dan Carpenter
2021-04-02 12:40 ` Fabio Aiuto
2021-04-02 12:47 ` Greg KH
2021-04-02 12:54 ` Fabio Aiuto
2021-04-02 10:01 ` [PATCH 02/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_security.c Fabio Aiuto
2021-04-02 10:01 ` [PATCH 03/16] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_eeprom.c Fabio Aiuto
2021-04-02 10:01 ` [PATCH 04/16] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_pwrctrl.c Fabio Aiuto
2021-04-02 10:01 ` [PATCH 05/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_cmd.c Fabio Aiuto
2021-04-02 10:01 ` [PATCH 06/16] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_mlme.c Fabio Aiuto
2021-04-02 10:01 ` [PATCH 07/16] staging: rtl8723bs: remove RT_TRACE logs " Fabio Aiuto
2021-04-02 10:01 ` [PATCH 08/16] staging: rtl8723bs: tidy up some error handling Fabio Aiuto
2021-04-02 10:01 ` [PATCH 09/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_mlme_ext.c Fabio Aiuto
2021-04-02 10:01 ` [PATCH 10/16] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_recv.c Fabio Aiuto
2021-04-02 10:01 ` [PATCH 11/16] staging: rtl8723bs: remove RT_TRACE logs " Fabio Aiuto
2021-04-02 10:01 ` [PATCH 12/16] staging: rtl8723bs: remove commented RT_TRACE call in core/rtw_ioctl_set.c Fabio Aiuto
2021-04-02 10:01 ` [PATCH 13/16] staging: rtl8723bs: remove RT_TRACE logs " Fabio Aiuto
2021-04-02 10:01 ` [PATCH 14/16] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.c Fabio Aiuto
2021-04-02 10:37 ` Joe Perches
2021-04-02 12:51 ` Fabio Aiuto
2021-04-02 15:20 ` Joe Perches
2021-04-02 17:40 ` Fabio Aiuto
2021-04-02 18:37 ` Joe Perches
2021-04-03 7:29 ` Fabio Aiuto [this message]
2021-04-02 12:05 ` kernel test robot
2021-04-02 10:01 ` [PATCH 15/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_sta_mgt.c Fabio Aiuto
2021-04-02 10:01 ` [PATCH 16/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_ieee80211.c Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210403072933.GA1563@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).